Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1184863002: Revert of Import functionality for new GL backend (Closed)

Created:
5 years, 6 months ago by djsollen
Modified:
5 years, 6 months ago
Reviewers:
Chris Dalton, bsalomon
CC:
reviews_skia.org, joshualitt
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Import functionality for new GL backend (patchset #2 id:20001 of https://codereview.chromium.org/1185573003/) Reason for revert: breaking multiple builds. For example... https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/667 Original issue's description: > Import functionality for new GL backend > > Brings in the following functionality: > > ARB_draw_instanced > ARB_instanced_arrays > NV_bindless_texture > EXT_direct_state_access > KHR_debug > > Also cleans up some of the NVPR extension loading. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/202c4c75fb806f751cf796850bf67fe9793e0643 TBR=bsalomon@google.com,cdalton@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1fe1858a90532f4db578bffb97936742d39ede49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -984 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 2 chunks +199 lines, -344 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 3 chunks +6 lines, -144 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 4 chunks +4 lines, -191 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 4 chunks +0 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 7 chunks +3 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -39 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 3 chunks +9 lines, -178 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 3 chunks +0 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 3 chunks +0 lines, -16 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
Created Revert of Import functionality for new GL backend
5 years, 6 months ago (2015-06-12 19:00:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184863002/1
5 years, 6 months ago (2015-06-12 19:01:06 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 19:01:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1fe1858a90532f4db578bffb97936742d39ede49

Powered by Google App Engine
This is Rietveld 408576698