test/cctest/test-heap.cc - Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 1184723002: Remove the --collect-maps flag. Maps should be always collected. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index 3b163da600d70fdb7c34a381642246b783b39d59..e7d4f793614c79425f48301b8095de7d49c05688 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -3407,7 +3407,6 @@ TEST(TransitionArraySimpleToFull) {

TEST(Regress2143a) {

- i::FLAG_collect_maps = true;

i::FLAG_incremental_marking = true;

CcTest::InitializeVM();

v8::HandleScope scope(CcTest::isolate());

@@ -3447,7 +3446,6 @@ TEST(Regress2143a) {

TEST(Regress2143b) {

- i::FLAG_collect_maps = true;

i::FLAG_incremental_marking = true;

i::FLAG_allow_natives_syntax = true;

CcTest::InitializeVM();

« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »