Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: src/compiler/node-marker.h

Issue 1184693002: [turbofan] Inline hot functions for NodeMarkerBase. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/node-marker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/node-marker.h
diff --git a/src/compiler/node-marker.h b/src/compiler/node-marker.h
index 853ba2228814ba8d0032428c1b81f1fec7ea1714..9ce03b054b48a4167ca54e79ef9f03c96cf42cdf 100644
--- a/src/compiler/node-marker.h
+++ b/src/compiler/node-marker.h
@@ -5,7 +5,7 @@
#ifndef V8_COMPILER_NODE_MARKER_H_
#define V8_COMPILER_NODE_MARKER_H_
-#include "src/base/macros.h"
+#include "src/compiler/node.h"
namespace v8 {
namespace internal {
@@ -13,13 +13,6 @@ namespace compiler {
// Forward declarations.
class Graph;
-class Node;
-
-
-// Marks are used during traversal of the graph to distinguish states of nodes.
-// Each node has a mark which is a monotonically increasing integer, and a
-// {NodeMarker} has a range of values that indicate states of a node.
-typedef uint32_t Mark;
// Base class for templatized NodeMarkers.
@@ -27,8 +20,20 @@ class NodeMarkerBase {
public:
NodeMarkerBase(Graph* graph, uint32_t num_states);
- Mark Get(Node* node);
- void Set(Node* node, Mark mark);
+ V8_INLINE Mark Get(Node* node) {
+ Mark mark = node->mark();
+ if (mark < mark_min_) {
+ mark = mark_min_;
+ node->set_mark(mark_min_);
+ }
+ DCHECK_LT(mark, mark_max_);
+ return mark - mark_min_;
+ }
+ V8_INLINE void Set(Node* node, Mark mark) {
+ DCHECK_LT(mark, mark_max_ - mark_min_);
+ DCHECK_LT(node->mark(), mark_max_);
+ node->set_mark(mark + mark_min_);
+ }
void Reset(Graph* graph);
private:
@@ -44,14 +49,14 @@ class NodeMarkerBase {
template <typename State>
class NodeMarker : public NodeMarkerBase {
public:
- NodeMarker(Graph* graph, uint32_t num_states)
+ V8_INLINE NodeMarker(Graph* graph, uint32_t num_states)
: NodeMarkerBase(graph, num_states) {}
- State Get(Node* node) {
+ V8_INLINE State Get(Node* node) {
return static_cast<State>(NodeMarkerBase::Get(node));
}
- void Set(Node* node, State state) {
+ V8_INLINE void Set(Node* node, State state) {
NodeMarkerBase::Set(node, static_cast<Mark>(state));
}
};
« no previous file with comments | « no previous file | src/compiler/node-marker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698