Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1184693002: [turbofan] Inline hot functions for NodeMarkerBase. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -32 lines) Patch
M src/compiler/node-marker.h View 4 chunks +18 lines, -13 lines 0 comments Download
M src/compiler/node-marker.cc View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-12 07:29:18 UTC) #1
Benedikt Meurer
Hey Jaro, These show up high in the profile for small functions. Please take a ...
5 years, 6 months ago (2015-06-12 07:29:47 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-12 08:04:30 UTC) #3
Benedikt Meurer
5 years, 6 months ago (2015-06-12 08:05:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd3edf37e1a1ecf158b1ec57904558b5afddd5e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698