[Android] Remove search feature from enhanced bookmarks

[Android] Remove search feature from enhanced bookmarks

BUG=499415
Committed: https://crrev.com/e1ad2c6d55fcbc679651ab7c2e27deded8e9cf07
Cr-Commit-Position: refs/heads/master@{#334459}

[Kibeom Kim (inactive), 2015-06-12 00:37:59]

kkimlabs@chromium.org changed reviewers:
+ ianwen@chromium.org, tedchoc@chromium.org, twellington@chromium.org

[Ian Wen, 2015-06-12 01:08:34]

This CL makes feel sad. :(

https://codereview.chromium.org/1184613002/diff/20001/chrome/android/java_sta...
File chrome/android/java_staging/res/layout-sw720dp/eb_main.xml (right):

https://codereview.chromium.org/1184613002/diff/20001/chrome/android/java_sta...
chrome/android/java_staging/res/layout-sw720dp/eb_main.xml:10:
android:background="@color/default_primary_color" >
Why background is changed? IIRC adding a background to the root view of an xml
will lead to a lint warning. The recommended way is to update the window
background of an activity.

I believe in our case we wanted to swiftly change the background between list
and grid view, so we did not put background in the linearlayout. I recommend you
not change the background here.

[Kibeom Kim (inactive), 2015-06-12 01:23:54]

https://codereview.chromium.org/1184613002/diff/20001/chrome/android/java_sta...
File chrome/android/java_staging/res/layout-sw720dp/eb_main.xml (right):

https://codereview.chromium.org/1184613002/diff/20001/chrome/android/java_sta...
chrome/android/java_staging/res/layout-sw720dp/eb_main.xml:10:
android:background="@color/default_primary_color" >
On 2015/06/12 01:08:34, Ian Wen wrote:
> Why background is changed? IIRC adding a background to the root view of an xml
> will lead to a lint warning. The recommended way is to update the window
> background of an activity.
> 
> I believe in our case we wanted to swiftly change the background between list
> and grid view, so we did not put background in the linearlayout. I recommend
you
> not change the background here.

This is tablet so it's not a root view. I'm just moving below two
android:background="@color/default_primary_color" to the top.

But anyways there is top padding background issue(I believe this is the reason
we didn't put the background in LinearLayout back then), I'll fix in the next
patchset.

[Ted C, 2015-06-12 19:07:31]

lgtm

[Ian Wen, 2015-06-12 20:18:34]

not lgtm. :(

1. This CL will make tabstrip on Nexus 9 invisible.
2. The random background change should not sneak in this CL. If we would like to
change the implementation about how the background is drawn, a separate bug and
CL should be created.

I am okay with removing-the-search part though.

[Kibeom Kim (inactive), 2015-06-12 20:33:29]

On 2015/06/12 20:18:34, Ian Wen wrote:
> not lgtm. :(
> 
> 1. This CL will make tabstrip on Nexus 9 invisible.
> 2. The random background change should not sneak in this CL. If we would like
to
> change the implementation about how the background is drawn, a separate bug
and
> CL should be created.
> 
> I am okay with removing-the-search part though.

Yeah but the background of ViewSwitcher we deleted should go somewhere. I'm
working on using margin instead of padding to workaround the  tapstrip overlap
issue.

[Theresa, 2015-06-15 18:37:59]

lgtm 

wrt to the Nexus 9 tabstrip issue, if it's easy to fix, I'd prefer to see it
with this patch. If it's not easy/will take longer to sort out, I think it's
fine to land this patch and do the fix as a separate small CL (that can be
merged back if we necessary).

[Kibeom Kim (inactive), 2015-06-15 19:23:36]

The CQ bit was checked by kkimlabs@chromium.org to run a CQ dry run

[Kibeom Kim (inactive), 2015-06-15 19:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/1184613002/#ps40001
(title: "rebase")

[Kibeom Kim (inactive), 2015-06-15 19:24:22]

Ian: ptal. This CL is fine as it as once
https://codereview.chromium.org/1182453003/ lands.

[commit-bot: I haz the power, 2015-06-15 19:24:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184613002/40001

[Ian Wen, 2015-06-15 19:39:12]

lgtm. Thanks!

[Kibeom Kim (inactive), 2015-06-15 19:41:09]

The CQ bit was unchecked by kkimlabs@chromium.org

[Kibeom Kim (inactive), 2015-06-15 19:41:14]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2015-06-15 19:41:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184613002/40001

[commit-bot: I haz the power, 2015-06-15 21:17:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-15 21:17:56]

Patchset 3 (id:??) landed as
https://crrev.com/e1ad2c6d55fcbc679651ab7c2e27deded8e9cf07
Cr-Commit-Position: refs/heads/master@{#334459}