Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 1184613002: [Android] Remove search feature from enhanced bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/bookmarks_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmarks_bridge.cc b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
index 486850ae8cd2af284ec0f7476c37db6cfb489b18..f3a6669c05b2a0146bfd5abbd7148c5dd106a654 100644
--- a/chrome/browser/android/bookmarks/bookmarks_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmarks_bridge.cc
@@ -656,45 +656,6 @@ void BookmarksBridge::MoveBookmark(JNIEnv* env,
bookmark_model_->Move(node, new_parent_node, index);
}
-void BookmarksBridge::SearchBookmarks(JNIEnv* env,
- jobject obj,
- jobject j_list,
- jstring j_query,
- jint max_results) {
- DCHECK(bookmark_model_->loaded());
-
- std::vector<bookmarks::BookmarkMatch> results;
- bookmark_model_->GetBookmarksMatching(
- base::android::ConvertJavaStringToUTF16(env, j_query),
- max_results,
- query_parser::MatchingAlgorithm::ALWAYS_PREFIX_SEARCH,
- &results);
- for (const bookmarks::BookmarkMatch& match : results) {
- const BookmarkNode* node = match.node;
-
- std::vector<int> title_match_start_positions;
- std::vector<int> title_match_end_positions;
- for (auto position : match.title_match_positions) {
- title_match_start_positions.push_back(position.first);
- title_match_end_positions.push_back(position.second);
- }
-
- std::vector<int> url_match_start_positions;
- std::vector<int> url_match_end_positions;
- for (auto position : match.url_match_positions) {
- url_match_start_positions.push_back(position.first);
- url_match_end_positions.push_back(position.second);
- }
-
- Java_BookmarksBridge_addToBookmarkMatchList(
- env, j_list, node->id(), node->type(),
- ToJavaIntArray(env, title_match_start_positions).obj(),
- ToJavaIntArray(env, title_match_end_positions).obj(),
- ToJavaIntArray(env, url_match_start_positions).obj(),
- ToJavaIntArray(env, url_match_end_positions).obj());
- }
-}
-
ScopedJavaLocalRef<jobject> BookmarksBridge::AddBookmark(
JNIEnv* env,
jobject obj,

Powered by Google App Engine
This is Rietveld 408576698