Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 118453006: Mac: Send a synthetic mouseup event when <select> popup menu is opened. (Closed)

Created:
7 years ago by tkent
Modified:
7 years ago
Reviewers:
keishi, Hajime Morrita
CC:
blink-reviews
Visibility:
Public.

Description

Mac: Send a synthetic mouseup event when <select> popup menu is opened. On Mac, 'mouseup' and 'click' events were not dispatched when <select> popup menu was opened because a popup menu is opened by a mousedown event, the menu is overlaped on the host <select>, and mouseup event is not routed to the page. This behaivor made some compatibility problems. We make a synthetic mouseup event in this case. Blink core dipatches 'mosueup' and 'click' events for it. This workaround is very similar to one in Mac Safari. BUG=36518 R=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -15 lines) Patch
A LayoutTests/platform/mac/fast/forms/select/menulist-click.html View 1 chunk +24 lines, -0 lines 0 comments Download
A + LayoutTests/platform/mac/fast/forms/select/menulist-click-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ExternalPopupMenu.h View 3 chunks +8 lines, -5 lines 0 comments Download
M Source/web/ExternalPopupMenu.cpp View 3 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
7 years ago (2013-12-19 04:28:43 UTC) #1
tkent
Morita-san, can you review this?
7 years ago (2013-12-20 04:34:55 UTC) #2
Hajime Morrita
lgtm.
7 years ago (2013-12-20 05:17:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/118453006/1
7 years ago (2013-12-20 05:19:06 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-20 07:31:16 UTC) #5
Message was sent while issue was closed.
Change committed as 164215

Powered by Google App Engine
This is Rietveld 408576698