Mac: Send a synthetic mouseup event when <select> popup menu is opened.

Source/web/ExternalPopupMenu.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "ExternalPopupMenu.h"
 
 #include "WebExternalPopupMenu.h"
 #include "WebMenuItemInfo.h"
 #include "WebPopupMenuInfo.h"
 #include "WebViewClient.h"
+#include "WebViewImpl.h"
 #include "core/frame/Frame.h"
 #include "core/frame/FrameView.h"
 #include "platform/PopupMenuClient.h"
 #include "platform/geometry/FloatQuad.h"
 #include "platform/geometry/IntPoint.h"
 #include "platform/text/TextDirection.h"
 #include "public/platform/WebVector.h"
 
 using namespace WebCore;
 
 namespace blink {
 
-ExternalPopupMenu::ExternalPopupMenu(Frame& frame, PopupMenuClient* popupMenuClient, WebViewClient* webViewClient)
+ExternalPopupMenu::ExternalPopupMenu(Frame& frame, PopupMenuClient* popupMenuClient, WebViewImpl& webView)
     : m_popupMenuClient(popupMenuClient)
     , m_frameView(frame.view())
-    , m_webViewClient(webViewClient)
+    , m_webView(webView)
+    , m_dispatchEventTimer(this, &ExternalPopupMenu::dispatchEvent)
     , m_webExternalPopupMenu(0)
 {
 }
 
 ExternalPopupMenu::~ExternalPopupMenu()
 {
 }
 
 void ExternalPopupMenu::show(const FloatQuad& controlPosition, const IntSize&, int index)
 {
     IntRect rect(controlPosition.enclosingBoundingBox());
     // WebCore reuses the PopupMenu of a page.
     // For simplicity, we do recreate the actual external popup everytime.
     hide();
 
     WebPopupMenuInfo info;
     getPopupMenuInfo(&info);
     if (info.items.isEmpty())
         return;
-    m_webExternalPopupMenu =
-        m_webViewClient->createExternalPopupMenu(info, this);
-    if (m_webExternalPopupMenu)
+    m_webExternalPopupMenu = m_webView.client()->createExternalPopupMenu(info, this);
+    if (m_webExternalPopupMenu) {
         m_webExternalPopupMenu->show(m_frameView->contentsToWindow(rect));
-    else {
+#if OS(MACOSX)
+        const WebInputEvent* currentEvent = WebViewImpl::currentInputEvent();
+        if (currentEvent && currentEvent->type == WebInputEvent::MouseDown) {
+            m_syntheticEvent = adoptPtr(new WebMouseEvent);
+            *m_syntheticEvent = *static_cast<const WebMouseEvent*>(currentEvent);
+            m_syntheticEvent->type = WebInputEvent::MouseUp;
+            m_dispatchEventTimer.startOneShot(0);
+            // FIXME: show() is asynchronous. If preparing a popup is slow and
+            // a user released the mouse button before showing the popup,
+            // mouseup and click events are correctly dispatched. Dispatching
+            // the synthetic mouseup event is redundant in this case.
+        }
+#endif
+    } else {
         // The client might refuse to create a popup (when there is already one pending to be shown for example).
         didCancel();
     }
 }
 
+void ExternalPopupMenu::dispatchEvent(Timer<ExternalPopupMenu>*)
+{
+    m_webView.handleInputEvent(*m_syntheticEvent);
+    m_syntheticEvent.clear();
+}
+
 void ExternalPopupMenu::hide()
 {
     if (m_popupMenuClient)
         m_popupMenuClient->popupDidHide();
     if (!m_webExternalPopupMenu)
         return;
     m_webExternalPopupMenu->close();
     m_webExternalPopupMenu = 0;
 }
 
@@ skipping 93 matching lines @@
 
     info->itemHeight = m_popupMenuClient->menuStyle().font().fontMetrics().height();
     info->itemFontSize = static_cast<int>(m_popupMenuClient->menuStyle().font().size());
     info->selectedIndex = m_popupMenuClient->selectedIndex();
     info->rightAligned = m_popupMenuClient->menuStyle().textDirection() == WebCore::RTL;
     info->allowMultipleSelection = m_popupMenuClient->multiple();
     info->items.swap(items);
 }
 
 }