Add support for the audio-output-device switching IPC mechanism to the renderer lower layers (media…

Add support for the audio-output-device switching IPC mechanism to the renderer lower layers (media::AudioOutputDevice, content::AudioMessageFilter and related classes).

The idea is to provide support for the Audio Output Devices API (http://w3c.github.io/mediacapture-output/)

BUG=438023
Committed: https://crrev.com/8c7fc2c8746c9cb294a5906572f23fbfc34726b3
Cr-Commit-Position: refs/heads/master@{#334451}

Committed: https://crrev.com/a0037e4cbf52a6e92e3fa01fafbd7e3667cccf37
Cr-Commit-Position: refs/heads/master@{#334520}

[Guido Urdaneta, 2015-06-11 17:46:30]

guidou@chromium.org changed reviewers:
+ bbudge@chromium.org, dalecurtis@chromium.org, miu@chromium.org,
tommi@chromium.org

[Guido Urdaneta, 2015-06-11 17:53:03]

Hi,
Please review.

[DaleCurtis, 2015-06-11 17:58:48]

Nice to see this coming along! Do you plan to hook up the reverse of this?  I.e.
when a user plugs in a new device? Today we add an extra layer of
resampling/mixing/etc when this occurs.

https://codereview.chromium.org/1184473002/diff/1/media/base/audio_output_dev...
File media/base/audio_output_device_callback_util.h (right):

https://codereview.chromium.org/1184473002/diff/1/media/base/audio_output_dev...
media/base/audio_output_device_callback_util.h:5: // Provides an utility class
to support invocation of callbacks in the correct
Why not use media::BindToCurrentLoop?

[Guido Urdaneta, 2015-06-11 18:56:39]

On 2015/06/11 17:58:48, DaleCurtis wrote:
> Nice to see this coming along! Do you plan to hook up the reverse of this? 
I.e.
> when a user plugs in a new device? Today we add an extra layer of
> resampling/mixing/etc when this occurs.
> 

The plan is to add something like that in a future iteration.

>
https://codereview.chromium.org/1184473002/diff/1/media/base/audio_output_dev...
> File media/base/audio_output_device_callback_util.h (right):
> 
>
https://codereview.chromium.org/1184473002/diff/1/media/base/audio_output_dev...
> media/base/audio_output_device_callback_util.h:5: // Provides an utility class
> to support invocation of callbacks in the correct
> Why not use media::BindToCurrentLoop?

Didn't know about it. Will use it. It will be simplify the code.

[bbudge, 2015-06-11 20:07:10]

content/renderer/pepper lgtm

[Guido Urdaneta, 2015-06-11 20:10:10]

https://codereview.chromium.org/1184473002/diff/1/media/base/audio_output_dev...
File media/base/audio_output_device_callback_util.h (right):

https://codereview.chromium.org/1184473002/diff/1/media/base/audio_output_dev...
media/base/audio_output_device_callback_util.h:5: // Provides an utility class
to support invocation of callbacks in the correct
On 2015/06/11 17:58:47, DaleCurtis wrote:
> Why not use media::BindToCurrentLoop?

Done.

[miu, 2015-06-12 21:25:14]

lgtm.  Looks like all my concerns from the original issue were addressed in this
one.  Thanks!  :)

[tommi (sloooow) - chröme, 2015-06-13 06:16:04]

lgtm w/ fixing of style for non-global const variables

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
File media/audio/audio_output_device_unittest.cc (right):

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
media/audio/audio_output_device_unittest.cc:216: const GURL
kSecurityOrigin("http://localhost");
this should just be security_origin.

the style guide says this about constants:
"Use a k followed by mixed case, e.g., kDaysInAWeek, for constants defined
globally or within a class."

This isn't global or static within a class (think compile time).

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
media/audio/audio_output_device_unittest.cc:217: const std::string kDeviceId =
"";
device_id
(and don't think that initialization to "" is necessary)

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
media/audio/audio_output_device_unittest.cc:218: const int kRequestId = 1;
request_id

[Guido Urdaneta, 2015-06-13 10:45:51]

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
File media/audio/audio_output_device_unittest.cc (right):

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
media/audio/audio_output_device_unittest.cc:216: const GURL
kSecurityOrigin("http://localhost");
On 2015/06/13 06:16:04, tommi wrote:
> this should just be security_origin.
> 
> the style guide says this about constants:
> "Use a k followed by mixed case, e.g., kDaysInAWeek, for constants defined
> globally or within a class."
> 
> This isn't global or static within a class (think compile time).

Done.

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
media/audio/audio_output_device_unittest.cc:217: const std::string kDeviceId =
"";
On 2015/06/13 06:16:04, tommi wrote:
> device_id
> (and don't think that initialization to "" is necessary)

Done.

https://codereview.chromium.org/1184473002/diff/100001/media/audio/audio_outp...
media/audio/audio_output_device_unittest.cc:218: const int kRequestId = 1;
On 2015/06/13 06:16:04, tommi wrote:
> request_id

Done.

[Guido Urdaneta, 2015-06-15 08:42:56]

guidou@chromium.org changed reviewers:
+ mkwst@chromium.org

[DaleCurtis, 2015-06-15 16:58:30]

lgtm

https://codereview.chromium.org/1184473002/diff/160001/media/audio/audio_outp...
File media/audio/audio_output_device.cc (right):

https://codereview.chromium.org/1184473002/diff/160001/media/audio/audio_outp...
media/audio/audio_output_device.cc:86:
current_switch_callback_->Run(SWITCH_OUTPUT_DEVICE_RESULT_ERROR_OBSOLETE);
you can use base::ResetAndReturn() to achieve this.

[Guido Urdaneta, 2015-06-15 19:07:27]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2015-06-15 19:07:28]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
tommi@chromium.org, miu@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1184473002/#ps180001
(title: "Use ResetAndReturn to reset and run callback")

[commit-bot: I haz the power, 2015-06-15 19:08:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184473002/180001

[commit-bot: I haz the power, 2015-06-15 20:41:48]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-06-15 20:43:28]

Patchset 10 (id:??) landed as
https://crrev.com/8c7fc2c8746c9cb294a5906572f23fbfc34726b3
Cr-Commit-Position: refs/heads/master@{#334451}

[Jamie Madill, 2015-06-15 21:27:29]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1186943003/ by jmadill@chromium.org.

The reason for reverting is: Breaking the GPU.FYI debug builders.

Sample output:

FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool
link-with-manifests environment.x86 True audio_unittests.exe
"C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
environment.x86 False link.exe /nologo /OUT:audio_unittests.exe
@audio_unittests.exe.rsp" 1 mt.exe rc.exe
"obj\media\audio_unittests.audio_unittests.exe.intermediate.manifest"
obj\media\audio_unittests.audio_unittests.exe.generated.manifest
..\..\build\win\compatibility.manifest
audio_unittests.audio_output_device_unittest.obj : error LNK2019: unresolved
external symbol "__declspec(dllimport) public: __thiscall GURL::GURL(class GURL
const &)" (__imp_??0GURL@@QAE@ABV0@@Z) referenced in function "public:
__thiscall testing::internal::ComparisonBase<class
testing::internal::EqMatcher<class GURL>,class GURL,struct
testing::internal::AnyEq>::ComparisonBase<class
testing::internal::EqMatcher<class GURL>,class GURL,struct
testing::internal::AnyEq>(class GURL const &)"
(??0?$ComparisonBase@V?$EqMatcher@VGURL@@@internal@testing@@VGURL@@UAnyEq@23@@internal@testing@@QAE@ABVGURL@@@Z)

audio_unittests.audio_output_device_unittest.obj : error LNK2019: unresolved
external symbol "__declspec(dllimport) public: __thiscall GURL::GURL(class
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char>
> const &)"
(__imp_??0GURL@@QAE@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
referenced in function "public: void __thiscall
media::AudioOutputDeviceTest::SwitchOutputDevice(void)"
(?SwitchOutputDevice@AudioOutputDeviceTest@media@@QAEXXZ)

audio_unittests.audio_output_device_unittest.obj : error LNK2019: unresolved
external symbol "__declspec(dllimport) public: __thiscall GURL::~GURL(void)"
(__imp_??1GURL@@QAE@XZ) referenced in function "class
testing::internal::EqMatcher<class GURL> __cdecl testing::Eq<class GURL>(class
GURL)" (??$Eq@VGURL@@@testing@@YA?AV?$EqMatcher@VGURL@@@internal@0@VGURL@@@Z)

audio_unittests.audio_output_device_unittest.obj : error LNK2019: unresolved
external symbol "__declspec(dllimport) public: bool __thiscall
GURL::operator==(class GURL const &)const " (__imp_??8GURL@@QBE_NABV0@@Z)
referenced in function "public: bool __thiscall
testing::internal::AnyEq::operator()<class GURL,class GURL>(class GURL const
&,class GURL const &)const "
(??$?RVGURL@@V0@@AnyEq@internal@testing@@QBE_NABVGURL@@0@Z)

audio_unittests.audio_output_device_unittest.obj : error LNK2019: unresolved
external symbol "__declspec(dllimport) class std::basic_ostream<char,struct
std::char_traits<char> > & __cdecl operator<<(class
std::basic_ostream<char,struct std::char_traits<char> > &,class GURL const &)"
(__imp_??6@YAAAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AAV01@ABVGURL@@@Z)
referenced in function "void __cdecl
testing_internal::DefaultPrintNonContainerTo<class GURL>(class GURL const
&,class std::basic_ostream<char,struct std::char_traits<char> > *)"
(??$DefaultPrintNonContainerTo@VGURL@@@testing_internal@@YAXABVGURL@@PAV?$basic_ostream@DU?$char_traits@D@std@@@std@@@Z)

audio_unittests.exe : fatal error LNK1120: 5 unresolved externals

BUG=438023.

[skobes, 2015-06-15 21:32:57]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1191523005/ by skobes@chromium.org.

The reason for reverting is: Linker errors on Win x64 Builder (dbg):

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28db...

audio_unittests.audio_output_device_unittest.obj : error LNK2019: unresolved
external symbol "__declspec(dllimport) public: __cdecl GURL::GURL(class GURL
const &)" (__imp_??0GURL@@QEAA@AEBV0@@Z) referenced in function "public: __cdecl
testing::internal::ComparisonBase<class testing::internal::EqMatcher<class
GURL>,class GURL,struct testing::internal::AnyEq>::ComparisonBase<class
testing::internal::EqMatcher<class GURL>,class GURL,struct
testing::internal::AnyEq>(class GURL const &)"
(??0?$ComparisonBase@V?$EqMatcher@VGURL@@@internal@testing@@VGURL@@UAnyEq@23@@internal@testing@@QEAA@AEBVGURL@@@Z)
...
audio_unittests.exe : fatal error LNK1120: 5 unresolved externals.

[Guido Urdaneta, 2015-06-15 23:56:55]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2015-06-15 23:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
bbudge@chromium.org, dalecurtis@chromium.org, miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1184473002/#ps200001
(title: "Fix build dependencies for audio_unittests")

[commit-bot: I haz the power, 2015-06-15 23:59:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184473002/200001

[commit-bot: I haz the power, 2015-06-16 00:54:04]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-06-16 00:55:10]

Patchset 11 (id:??) landed as
https://crrev.com/a0037e4cbf52a6e92e3fa01fafbd7e3667cccf37
Cr-Commit-Position: refs/heads/master@{#334520}