Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 118443008: Support cross-process navigations in a single subframe RenderFrameHost. (Closed)

Created:
7 years ago by Charlie Reis
Modified:
6 years, 12 months ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Support cross-process navigations in a single subframe RenderFrameHost. This relies on a hack of detecting when a NavigationEntry is for a subframe RenderFrameHost, even though the navigation occurs in a top-level RenderViewHost. It supports cases with at most one frame, and is only enabled when --site-per-process is used. BUG=314791 TEST=New process is created for a cross-site iframe with --site-per-process. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242639

Patch Set 1 #

Patch Set 2 : Add test and lots of cleanup. #

Patch Set 3 : Minor cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -114 lines) Patch
M content/browser/frame_host/frame_tree.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 3 chunks +17 lines, -3 lines 1 comment Download
M content/browser/frame_host/navigation_controller_impl.cc View 19 chunks +40 lines, -28 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 23 chunks +30 lines, -24 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 7 chunks +38 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +12 lines, -6 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 chunks +38 lines, -18 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 7 chunks +77 lines, -9 lines 1 comment Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Ok, this one's working and has a test now. Should be ready for review. https://codereview.chromium.org/118443008/diff/50001/content/browser/frame_host/navigation_controller_impl.h ...
7 years ago (2013-12-20 23:20:08 UTC) #1
nasko
LGTM
6 years, 12 months ago (2013-12-27 19:34:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/118443008/50001
6 years, 12 months ago (2013-12-27 19:35:00 UTC) #3
commit-bot: I haz the power
6 years, 12 months ago (2013-12-27 21:56:25 UTC) #4
Message was sent while issue was closed.
Change committed as 242639

Powered by Google App Engine
This is Rietveld 408576698