Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 118443008: Support cross-process navigations in a single subframe RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor cleanup Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.h
diff --git a/content/browser/frame_host/navigation_controller_impl.h b/content/browser/frame_host/navigation_controller_impl.h
index 99fc36ae00209adf8958624d920b82ce251c5d6c..e9206b4b72430269b023cc1017832b0c51c7e43b 100644
--- a/content/browser/frame_host/navigation_controller_impl.h
+++ b/content/browser/frame_host/navigation_controller_impl.h
@@ -134,7 +134,10 @@ class CONTENT_EXPORT NavigationControllerImpl
//
// In the case that nothing has changed, the details structure is undefined
// and it will return false.
- bool RendererDidNavigate(const ViewHostMsg_FrameNavigate_Params& params,
+ //
+ // TODO(creis): Change RenderViewHost to RenderFrameHost.
+ bool RendererDidNavigate(RenderViewHost* rvh,
Charlie Reis 2013/12/20 23:20:08 If you want, these changes to NavigationController
+ const ViewHostMsg_FrameNavigate_Params& params,
LoadCommittedDetails* details);
// Notifies us that we just became active. This is used by the WebContentsImpl
@@ -231,6 +234,7 @@ class CONTENT_EXPORT NavigationControllerImpl
// Classifies the given renderer navigation (see the NavigationType enum).
NavigationType ClassifyNavigation(
+ RenderViewHost* rvh,
const ViewHostMsg_FrameNavigate_Params& params) const;
// Causes the controller to load the specified entry. The function assumes
@@ -250,17 +254,27 @@ class CONTENT_EXPORT NavigationControllerImpl
// The functions taking |did_replace_entry| will fill into the given variable
// whether the last entry has been replaced or not.
// See LoadCommittedDetails.did_replace_entry.
+ //
+ // TODO(creis): Change RenderViewHost to RenderFrameHost.
void RendererDidNavigateToNewPage(
- const ViewHostMsg_FrameNavigate_Params& params, bool replace_entry);
+ RenderViewHost* rvh,
+ const ViewHostMsg_FrameNavigate_Params& params,
+ bool replace_entry);
void RendererDidNavigateToExistingPage(
+ RenderViewHost* rvh,
const ViewHostMsg_FrameNavigate_Params& params);
void RendererDidNavigateToSamePage(
+ RenderViewHost* rvh,
const ViewHostMsg_FrameNavigate_Params& params);
void RendererDidNavigateInPage(
- const ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry);
+ RenderViewHost* rvh,
+ const ViewHostMsg_FrameNavigate_Params& params,
+ bool* did_replace_entry);
void RendererDidNavigateNewSubframe(
+ RenderViewHost* rvh,
const ViewHostMsg_FrameNavigate_Params& params);
bool RendererDidNavigateAutoSubframe(
+ RenderViewHost* rvh,
const ViewHostMsg_FrameNavigate_Params& params);
// Helper function for code shared between Reload() and ReloadIgnoringCache().

Powered by Google App Engine
This is Rietveld 408576698