Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1184143006: Remove code using builder properties (Closed)

Created:
5 years, 6 months ago by sheyang
Modified:
5 years, 6 months ago
Reviewers:
dnj, Sergiy Byelozyorov
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M commit_queue.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sheyang
5 years, 6 months ago (2015-06-15 23:08:36 UTC) #2
Sergiy Byelozyorov
lgtm thanks for fixing this
5 years, 6 months ago (2015-06-15 23:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184143006/1
5 years, 6 months ago (2015-06-15 23:12:06 UTC) #5
dnj
lgtm
5 years, 6 months ago (2015-06-15 23:12:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/50)
5 years, 6 months ago (2015-06-15 23:17:22 UTC) #8
sheyang
5 years, 6 months ago (2015-06-15 23:19:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 295690.

Powered by Google App Engine
This is Rietveld 408576698