Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182053004: Updated cq_client to reflect latest changes in CQ repo (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Updated cq_client to reflect latest changes in CQ repo COMMIT=false (wait until devs will sync their Chromium and Blink checkouts, otherwise this will fail on reading old cq configs, which still contain properties field) R=tandrii@google.com BUG=497243, 499838

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Removed whitespace #

Patch Set 4 : Another fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -132 lines) Patch
M third_party/cq_client/cq.proto View 4 chunks +0 lines, -18 lines 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 2 3 14 chunks +15 lines, -114 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-12 16:29:33 UTC) #1
tandrii(chromium)
lgtm % if you fix your own request from the past :) https://codereview.chromium.org/1182053004/diff/1/third_party/cq_client/cq_pb2.py File third_party/cq_client/cq_pb2.py ...
5 years, 6 months ago (2015-06-12 16:35:36 UTC) #3
Sergiy Byelozyorov
https://codereview.chromium.org/1182053004/diff/1/third_party/cq_client/cq_pb2.py File third_party/cq_client/cq_pb2.py (left): https://codereview.chromium.org/1182053004/diff/1/third_party/cq_client/cq_pb2.py#oldcode9 third_party/cq_client/cq_pb2.py:9: On 2015/06/12 16:35:35, tandrii(chromium) wrote: > well, you should ...
5 years, 6 months ago (2015-06-12 17:25:48 UTC) #4
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-15 19:31:02 UTC) #5
Message was sent while issue was closed. 
On 2015/06/12 17:25:48, Sergiy Byelozyorov wrote:
>
https://codereview.chromium.org/1182053004/diff/1/third_party/cq_client/cq_pb...
> File third_party/cq_client/cq_pb2.py (left):
> 
>
https://codereview.chromium.org/1182053004/diff/1/third_party/cq_client/cq_pb...
> third_party/cq_client/cq_pb2.py:9: 
> On 2015/06/12 16:35:35, tandrii(chromium) wrote:
> > well, you should read your own comment, i guess :))))
> 
> Indeed. Thanks.

This is covered by https://codereview.chromium.org/1177953005/

Powered by Google App Engine
This is Rietveld 408576698