Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1184113003: Thorough tests for saturatedAdd and mulDiv255Round. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Thorough tests for saturatedAdd and mulDiv255Round. BUG=skia:3951 Committed: https://skia.googlesource.com/skia/+/ce9d11189a5924b47c3629063b72bae9d466c2c7 CQ_EXTRA_TRYBOTS=client.skia.android:Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot Committed: https://skia.googlesource.com/skia/+/374787534147f3a616925d297bce74ff575d8911

Patch Set 1 #

Patch Set 2 : fix portable saturatedAdd() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M src/core/SkNx.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/SkNxTest.cpp View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
mtklein
5 years, 6 months ago (2015-06-15 14:41:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184113003/1
5 years, 6 months ago (2015-06-15 14:41:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 14:46:38 UTC) #6
mtklein
lgtm
5 years, 6 months ago (2015-06-15 15:57:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184113003/1
5 years, 6 months ago (2015-06-15 15:57:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ce9d11189a5924b47c3629063b72bae9d466c2c7
5 years, 6 months ago (2015-06-15 15:58:25 UTC) #10
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1177123004/ by mtklein@google.com. ...
5 years, 6 months ago (2015-06-15 17:03:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184113003/20001
5 years, 6 months ago (2015-06-15 17:13:17 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Test-Android-GCC-Nexus5-CPU-NEON-Arm7-Release-Trybot on client.skia (JOB_FAILED, no build URL)
5 years, 6 months ago (2015-06-15 17:13:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184113003/20001
5 years, 6 months ago (2015-06-15 17:22:59 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 17:58:51 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/374787534147f3a616925d297bce74ff575d8911

Powered by Google App Engine
This is Rietveld 408576698