src/core/SkNx.h - Issue 1184113003: Thorough tests for saturatedAdd and mulDiv255Round.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkNx.h

Issue 1184113003: Thorough tests for saturatedAdd and mulDiv255Round. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: fix portable saturatedAdd() Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkNx.h

diff --git a/src/core/SkNx.h b/src/core/SkNx.h

index d968cad19f6c687b6ef41720425dbe22ddb1fbe2..1342266b934f9c007062323a677a5d6bf904a0e6 100644

--- a/src/core/SkNx.h

+++ b/src/core/SkNx.h

@@ -184,7 +184,7 @@ public:

SkNi saturatedAdd(const SkNi& o) const {

SkASSERT((T)(~0) > 0); // TODO: support signed T

T sum = fVal + o.fVal;

- return SkNi(sum > fVal ? sum : (T)(~0));

+ return SkNi(sum < fVal ? (T)(~0) : sum);

}

SkNi operator + (const SkNi& o) const { return SkNi(fVal + o.fVal); }

« no previous file with comments | « no previous file | tests/SkNxTest.cpp » ('j') | no next file with comments »