skia: Add runtime option to disable picture IO security precautions

skia: Add runtime option to disable picture IO security precautions

Replaced the compile time file IO security setting with a runtime setting.

Unfortunately the setting is global.

Committed: https://skia.googlesource.com/skia/+/446ee67fda73b11281b8e28a68edec811347c0c5

[hendrikw, 2015-06-16 15:33:55]

Patchset #2 (id:20001) has been deleted

[hendrikw, 2015-06-16 15:39:20]

hendrikw@chromium.org changed reviewers:
+ mtklein@google.com

[hendrikw, 2015-06-16 15:39:39]

PTAL, thanks!

https://codereview.chromium.org/1183853003/diff/40001/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/1183853003/diff/40001/src/core/SkPicture.cpp#...
src/core/SkPicture.cpp:18: defined(SK_ENABLE_PICTURE_IO_SECURITY_PRECAUTIONS)
There was a comment about renaming previously, I've included both the old and
new name so that we can update chrome, then remove
SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS.

I chose a different name, let me know if you agree or not.

In fact, let me know if you have better names for any of the functions /
variables.

[hendrikw, 2015-06-16 15:40:37]

https://codereview.chromium.org/1183853003/diff/40001/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/1183853003/diff/40001/src/core/SkPicture.cpp#...
src/core/SkPicture.cpp:18: defined(SK_ENABLE_PICTURE_IO_SECURITY_PRECAUTIONS)
On 2015/06/16 15:39:38, hendrikw wrote:
> There was a comment about renaming previously, I've included both the old and
> new name so that we can update chrome, then remove
> SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS.
> 
> I chose a different name, let me know if you agree or not.
> 
> In fact, let me know if you have better names for any of the functions /
> variables.

Oops, last minute change, I have the logic wrong here.  1 sec. :D

[hendrikw, 2015-06-16 15:42:35]

On 2015/06/16 15:40:37, hendrikw wrote:
> https://codereview.chromium.org/1183853003/diff/40001/src/core/SkPicture.cpp
> File src/core/SkPicture.cpp (right):
> 
>
https://codereview.chromium.org/1183853003/diff/40001/src/core/SkPicture.cpp#...
> src/core/SkPicture.cpp:18: defined(SK_ENABLE_PICTURE_IO_SECURITY_PRECAUTIONS)
> On 2015/06/16 15:39:38, hendrikw wrote:
> > There was a comment about renaming previously, I've included both the old
and
> > new name so that we can update chrome, then remove
> > SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS.
> > 
> > I chose a different name, let me know if you agree or not.
> > 
> > In fact, let me know if you have better names for any of the functions /
> > variables.
> 
> Oops, last minute change, I have the logic wrong here.  1 sec. :D

Actually, it's right.

[mtklein, 2015-06-16 15:57:48]

mtklein@google.com changed reviewers:
+ reed@google.com

[mtklein, 2015-06-16 15:57:49]

+reed to stamp the addition to our public API.

This looks good to me with the exception of a couple style nits.

https://codereview.chromium.org/1183853003/diff/60001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1183853003/diff/60001/include/core/SkPicture....
include/core/SkPicture.h:157: static void
setPictureIOSecurityPrecautionsEnabled_Dangerous(bool set);
Skia style makes static methods NamedLikeThis, so

SetPictureIOSecurityPrecautionsEnabled_Dangerous
PictureIOSecurityPrecautionsEnabled

https://codereview.chromium.org/1183853003/diff/60001/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/1183853003/diff/60001/src/core/SkPicture.cpp#...
src/core/SkPicture.cpp:19: bool gAllPictureIOSecurityPrecautionsEnabled = true;
Skia tends to use static where possible instead of namespace {} and name them
g_like_this, so

static bool g_all_picture_io_security_precautions_enabled

[hendrikw, 2015-06-16 16:09:37]

https://codereview.chromium.org/1183853003/diff/60001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1183853003/diff/60001/include/core/SkPicture....
include/core/SkPicture.h:157: static void
setPictureIOSecurityPrecautionsEnabled_Dangerous(bool set);
On 2015/06/16 15:57:49, mtklein wrote:
> Skia style makes static methods NamedLikeThis, so
> 
> SetPictureIOSecurityPrecautionsEnabled_Dangerous
> PictureIOSecurityPrecautionsEnabled

Done.

https://codereview.chromium.org/1183853003/diff/60001/src/core/SkPicture.cpp
File src/core/SkPicture.cpp (right):

https://codereview.chromium.org/1183853003/diff/60001/src/core/SkPicture.cpp#...
src/core/SkPicture.cpp:19: bool gAllPictureIOSecurityPrecautionsEnabled = true;
On 2015/06/16 15:57:49, mtklein wrote:
> Skia tends to use static where possible instead of namespace {} and name them
> g_like_this, so
> 
> static bool g_all_picture_io_security_precautions_enabled

Done.

[hendrikw, 2015-06-16 16:16:08]

PTAL

[reed1, 2015-06-16 16:21:01]

reed@google.com changed required reviewers:
+ mtklein@google.com

[reed1, 2015-06-16 16:21:02]

api lgtm

[mtklein, 2015-06-16 16:23:24]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-06-16 16:23:24]

lgtm

[commit-bot: I haz the power, 2015-06-16 16:23:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183853003/70001

[commit-bot: I haz the power, 2015-06-16 16:28:41]

Committed patchset #4 (id:70001) as
https://skia.googlesource.com/skia/+/446ee67fda73b11281b8e28a68edec811347c0c5