skia: Add runtime option to disable picture IO security precautions

src/core/SkPicture.cpp

 /*
  * Copyright 2007 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkAtomics.h"
 #include "SkMessageBus.h"
 #include "SkPicture.h"
 #include "SkPictureData.h"
 #include "SkPicturePlayback.h"
 #include "SkPictureRecord.h"
 #include "SkPictureRecorder.h"
 
+namespace {
+#if defined(SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS) || \
+    defined(SK_ENABLE_PICTURE_IO_SECURITY_PRECAUTIONS)

[hendrikw, 2015/06/16 15:39:38]

There was a comment about renaming previously, I've included both the old and
new name so that we can update chrome, then remove
SK_DISALLOW_CROSSPROCESS_PICTUREIMAGEFILTERS.

I chose a different name, let me know if you agree or not.

In fact, let me know if you have better names for any of the functions /
variables.

[hendrikw, 2015/06/16 15:40:37]

Oops, last minute change, I have the logic wrong here.  1 sec. :D

+bool gAllPictureIOSecurityPrecautionsEnabled = true;
+#else
+bool gAllPictureIOSecurityPrecautionsEnabled = false;
+#endif
+}  // namespac
+
 DECLARE_SKMESSAGEBUS_MESSAGE(SkPicture::DeletionMessage);
 
 /* SkPicture impl.  This handles generic responsibilities like unique IDs and serialization. */
 
 SkPicture::SkPicture() : fUniqueID(0) {}
 
 SkPicture::~SkPicture() {
     // TODO: move this to ~SkBigPicture() only?
 
     // If the ID is still zero, no one has read it, so no need to send this message.
@@ skipping 163 matching lines @@
     }
 }
 
 bool SkPicture::suitableForGpuRasterization(GrContext*, const char** whyNot) const {
     if (this->numSlowPaths() > 5) {
         if (whyNot) { *whyNot = "Too many slow paths (either concave or dashed)."; }
         return false;
     }
     return true;
 }
+
+// Global setting to disable security precautions for serialization.
+void SkPicture::setPictureIOSecurityPrecautionsEnabled_Dangerous(bool set) {
+  gAllPictureIOSecurityPrecautionsEnabled = set;
+}
+
+bool SkPicture::pictureIOSecurityPrecautionsEnabled() {
+  return gAllPictureIOSecurityPrecautionsEnabled;
+}