google_apis/gcm/tools/mcs_probe.cc - Issue 1183843002: Do not create GCM store if it is not needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/tools/mcs_probe.cc

Issue 1183843002: Do not create GCM store if it is not needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback + fix test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/tools/mcs_probe.cc

diff --git a/google_apis/gcm/tools/mcs_probe.cc b/google_apis/gcm/tools/mcs_probe.cc

index 8121f7c9af12459bc4a47d32532feee4e69a20e1..e1bd244d58fca38a9cee2d350e20af4561a35148 100644

--- a/google_apis/gcm/tools/mcs_probe.cc

+++ b/google_apis/gcm/tools/mcs_probe.cc

@@ -307,7 +307,8 @@ void MCSProbe::Start() {

gcm_store_.get(),

&recorder_));

run_loop_.reset(new base::RunLoop());

- gcm_store_->Load(base::Bind(&MCSProbe::LoadCallback,

+ gcm_store_->Load(GCMStore::CREATE_IF_MISSING,

+ base::Bind(&MCSProbe::LoadCallback,

base::Unretained(this)));

run_loop_->Run();

}