google_apis/gcm/engine/mcs_client_unittest.cc - Issue 1183843002: Do not create GCM store if it is not needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/mcs_client_unittest.cc

Issue 1183843002: Do not create GCM store if it is not needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback + fix test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/mcs_client_unittest.cc

diff --git a/google_apis/gcm/engine/mcs_client_unittest.cc b/google_apis/gcm/engine/mcs_client_unittest.cc

index 644c702ab76f7b50503163e4c93b6052c5fa11e8..44d8bc30072843e2d96a4064329e325d69a41f13 100644

--- a/google_apis/gcm/engine/mcs_client_unittest.cc

+++ b/google_apis/gcm/engine/mcs_client_unittest.cc

@@ -198,7 +198,7 @@ void MCSClientTest::BuildMCSClient() {

}

void MCSClientTest::InitializeClient() {

- gcm_store_->Load(base::Bind(

+ gcm_store_->Load(GCMStore::CREATE_IF_MISSING, base::Bind(

&MCSClient::Initialize,

base::Unretained(mcs_client_.get()),

base::Bind(&MCSClientTest::ErrorCallback,