Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 1183763003: Remove ArrayBufferDeallocationObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: move callback to WTF.cpp Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index c736a026d980b26815bb35978f8932c83643e13c..2ea915b76683c64fa1bd50b9bed328f022f6c49f 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -725,12 +725,8 @@ v8::Local<v8::Object> {{v8_class}}::findInstanceInPrototypeChain(v8::Local<v8::V
// Transfer the ownership of the allocated memory to an ArrayBuffer without
// copying.
v8::ArrayBuffer::Contents v8Contents = v8buffer->Externalize();
- WTF::ArrayBufferContents contents(v8Contents.Data(), v8Contents.ByteLength(), 0);
+ WTF::ArrayBufferContents contents(v8Contents.Data(), v8Contents.ByteLength());
RefPtr<{{cpp_class}}> buffer = {{cpp_class}}::create(contents);
- // Since this transfer doesn't allocate new memory, do not call
- // DOMArrayBufferDeallocationObserver::blinkAllocatedMemory.
- buffer->buffer()->setDeallocationObserverWithoutAllocationNotification(
- DOMArrayBufferDeallocationObserver::instance());
buffer->associateWithWrapper(v8::Isolate::GetCurrent(), buffer->wrapperTypeInfo(), object);
return buffer.get();

Powered by Google App Engine
This is Rietveld 408576698