Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: Source/bindings/tests/results/core/V8ArrayBuffer.cpp

Issue 1183763003: Remove ArrayBufferDeallocationObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: move callback to WTF.cpp Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8ArrayBuffer.cpp
diff --git a/Source/bindings/tests/results/core/V8ArrayBuffer.cpp b/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
index 4157aa78361040027a6c24f2324f3b7a2447925a..a491e06ccea842c83a4c278c9a1bb7a46e705998 100644
--- a/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
+++ b/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
@@ -12,7 +12,6 @@
#include "bindings/core/v8/V8DOMConfiguration.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
#include "core/dom/ContextFeatures.h"
-#include "core/dom/DOMArrayBufferDeallocationObserver.h"
#include "core/dom/Document.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/TraceEvent.h"
@@ -47,12 +46,8 @@ TestArrayBuffer* V8ArrayBuffer::toImpl(v8::Local<v8::Object> object)
// Transfer the ownership of the allocated memory to an ArrayBuffer without
// copying.
v8::ArrayBuffer::Contents v8Contents = v8buffer->Externalize();
- WTF::ArrayBufferContents contents(v8Contents.Data(), v8Contents.ByteLength(), 0);
+ WTF::ArrayBufferContents contents(v8Contents.Data(), v8Contents.ByteLength());
RefPtr<TestArrayBuffer> buffer = TestArrayBuffer::create(contents);
- // Since this transfer doesn't allocate new memory, do not call
- // DOMArrayBufferDeallocationObserver::blinkAllocatedMemory.
- buffer->buffer()->setDeallocationObserverWithoutAllocationNotification(
- DOMArrayBufferDeallocationObserver::instance());
buffer->associateWithWrapper(v8::Isolate::GetCurrent(), buffer->wrapperTypeInfo(), object);
return buffer.get();

Powered by Google App Engine
This is Rietveld 408576698