Make ResourceDispatcherHostImpl::DidReceiveResponse less repetitive

Make ResourceDispatcherHostImpl::DidReceiveResponse less repetitive

Initialise a |request| variable with the value of loader->request()
to avoid repeating it in 4 different places.

BUG=none
TEST=content_unittests

Committed: https://crrev.com/cae5a8f3fb76f261cd191e9a7b3e3deed30e63c2
Cr-Commit-Position: refs/heads/master@{#335228}

[Adam Rice, 2015-06-16 19:23:15]

ricea@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2015-06-18 07:08:49]

lgtm

[Adam Rice, 2015-06-18 08:16:56]

ricea@chromium.org changed reviewers:
+ mmenke@chromium.org

[Adam Rice, 2015-06-18 08:16:57]

+mmenke for OWNERS.

Background: https://codereview.chromium.org/1041993004/ will crease the number
of uses of |request| to 5. This refactoring was split off from that CL.

[mmenke, 2015-06-18 14:47:16]

LGTM.

Not sure it's really worth a separate patch, but I have no objections.

https://codereview.chromium.org/1183723006/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/1183723006/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:837: GetCertID(request,
info->GetChildID())));
optional:  Could merge this with the above line, now.

[tyoshino (SeeGerritForStatus), 2015-06-19 04:55:16]

On 2015/06/18 14:47:16, mmenke wrote:
> LGTM.
> 
> Not sure it's really worth a separate patch, but I have no objections.

Thanks for review.

I've suggested to do so as it reduces the diff on the main patch. Do you
recommend not to do like this basically?

[Adam Rice, 2015-06-19 06:59:17]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2015-06-19 06:59:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1183723006/#ps20001
(title: "Remove unnecessary line break.")

[commit-bot: I haz the power, 2015-06-19 06:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1183723006/20001

[Adam Rice, 2015-06-19 07:00:23]

https://codereview.chromium.org/1183723006/diff/1/content/browser/loader/reso...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/1183723006/diff/1/content/browser/loader/reso...
content/browser/loader/resource_dispatcher_host_impl.cc:837: GetCertID(request,
info->GetChildID())));
On 2015/06/18 14:47:15, mmenke wrote:
> optional:  Could merge this with the above line, now.

Done.

[commit-bot: I haz the power, 2015-06-19 08:33:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-19 08:34:34]

Patchset 2 (id:??) landed as
https://crrev.com/cae5a8f3fb76f261cd191e9a7b3e3deed30e63c2
Cr-Commit-Position: refs/heads/master@{#335228}

[mmenke, 2015-06-19 11:39:51]

On 2015/06/19 04:55:16, tyoshino wrote:
> On 2015/06/18 14:47:16, mmenke wrote:
> > LGTM.
> > 
> > Not sure it's really worth a separate patch, but I have no objections.
> 
> Thanks for review.
> 
> I've suggested to do so as it reduces the diff on the main patch. Do you
> recommend not to do like this basically?

I don't think this is quite substantial enough to be worth separating out - if
it were larger, or changed/fixed behavior, I'd agree.  Regardless, if you feel
it makes the other CL easier to review, it's the right call.

[tyoshino (SeeGerritForStatus), 2015-06-19 12:14:15]

On 2015/06/19 11:39:51, mmenke wrote:
> On 2015/06/19 04:55:16, tyoshino wrote:
> > On 2015/06/18 14:47:16, mmenke wrote:
> > > LGTM.
> > > 
> > > Not sure it's really worth a separate patch, but I have no objections.
> > 
> > Thanks for review.
> > 
> > I've suggested to do so as it reduces the diff on the main patch. Do you
> > recommend not to do like this basically?
> 
> I don't think this is quite substantial enough to be worth separating out - if
> it were larger, or changed/fixed behavior, I'd agree.  Regardless, if you feel
> it makes the other CL easier to review, it's the right call.

Got it.