Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1183513006: Revert of gpu: play skp files through the command buffer (Closed)

Created:
5 years, 6 months ago by hendrikw
Modified:
5 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, reed1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: play skp files through the command buffer (patchset #9 id:260001 of https://codereview.chromium.org/1149893010/) Reason for revert: Causes a build failure on continuous mac bots (succeeds on try bots though) Original issue's description: > gpu: play skp files through the command buffer > > Small utility program that can take an skp, or directory of skps and > GPU rasterizes them to png, through chrome's command buffer. > > BUG= > > Committed: https://crrev.com/6daedb499182a5b6b0bcd54004afb7ebb3c3443b > Cr-Commit-Position: refs/heads/master@{#334928} TBR=piman@chromium.org,vmiura@chromium.org,thakis@chromium.org,dpranke@chromium.org,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1bf897548c895bb2c0382cb991852fde622befd0 Cr-Commit-Position: refs/heads/master@{#334959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -623 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 2 chunks +1 line, -16 lines 0 comments Download
D gpu/skia_runner/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D gpu/skia_runner/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D gpu/skia_runner/in_process_graphics_system.h View 1 chunk +0 lines, -29 lines 0 comments Download
D gpu/skia_runner/in_process_graphics_system.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D gpu/skia_runner/sk_picture_rasterizer.h View 1 chunk +0 lines, -40 lines 0 comments Download
D gpu/skia_runner/sk_picture_rasterizer.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D gpu/skia_runner/skia_runner.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D gpu/skia_runner/skia_runner.gyp View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hendrikw
Created Revert of gpu: play skp files through the command buffer
5 years, 6 months ago (2015-06-17 23:23:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183513006/1
5 years, 6 months ago (2015-06-17 23:25:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 23:27:41 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 23:29:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bf897548c895bb2c0382cb991852fde622befd0
Cr-Commit-Position: refs/heads/master@{#334959}

Powered by Google App Engine
This is Rietveld 408576698