Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3172)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 1183513003: Ignore queued Safe Browsing interstitial requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 80e064240882802abe45f95a5340d14f6472d100..57d75ab1310c52146c98ac1d3414032583e966f0 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -19,11 +19,11 @@
// or allow it to continue.
//
// A web page may contain several resources flagged as malware/phishing. This
-// results into more than one interstitial being shown. On the first unsafe
-// resource received we show an interstitial. Any subsequent unsafe resource
-// notifications while the first interstitial is showing is queued. If the user
-// decides to proceed in the first interstitial, we display all queued unsafe
-// resources in a new interstitial.
+// might result in more than one interstitial being shown. On the first unsafe
+// resource received we show an interstitial. Any subsequent unsafe resource
+// notifications received while it is being displayed will be dropped. However
+// another resource might load at a later time and trigger the display of a new
+// interstitial.
#ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_
#define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_
@@ -51,7 +51,6 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
public:
typedef SafeBrowsingUIManager::UnsafeResource UnsafeResource;
typedef std::vector<UnsafeResource> UnsafeResourceList;
- typedef std::map<content::WebContents*, UnsafeResourceList> UnsafeResourceMap;
// Interstitial type, used in tests.
static content::InterstitialPageDelegate::TypeID kTypeForTesting;
@@ -124,11 +123,6 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
// enabled, the report is scheduled to be sent on the |ui_manager_|.
void FinishMalwareDetails(int64 delay_ms);
- // A list of SafeBrowsingUIManager::UnsafeResource for a tab that the user
- // should be warned about. They are queued when displaying more than one
- // interstitial at a time.
- static UnsafeResourceMap* GetUnsafeResourcesMap();
-
// Notifies the SafeBrowsingUIManager on the IO thread whether to proceed
// or not for the |resources|.
static void NotifySafeBrowsingUIManager(
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698