Ignore queued Safe Browsing interstitial requests

chrome/browser/safe_browsing/safe_browsing_blocking_page.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Classes for managing the SafeBrowsing interstitial pages.
 //
 // When a user is about to visit a page the SafeBrowsing system has deemed to
 // be malicious, either as malware or a phishing page, we show an interstitial
 // page with some options (go back, continue) to give the user a chance to avoid
 // the harmful page.
 //
 // The SafeBrowsingBlockingPage is created by the SafeBrowsingUIManager on the
 // UI thread when we've determined that a page is malicious. The operation of
 // the blocking page occurs on the UI thread, where it waits for the user to
 // make a decision about what to do: either go back or continue on.
 //
 // The blocking page forwards the result of the user's choice back to the
 // SafeBrowsingUIManager so that we can cancel the request for the new page,
 // or allow it to continue.
 //
 // A web page may contain several resources flagged as malware/phishing.  This
-// results into more than one interstitial being shown.  On the first unsafe
-// resource received we show an interstitial.  Any subsequent unsafe resource
-// notifications while the first interstitial is showing is queued.  If the user
-// decides to proceed in the first interstitial, we display all queued unsafe
-// resources in a new interstitial.
+// might result in more than one interstitial being shown. On the first unsafe
+// resource received we show an interstitial. Any subsequent unsafe resource
+// notifications received while it is being displayed will be dropped. However
+// another resource might load at a later time and trigger the display of a new
+// interstitial.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "chrome/browser/interstitials/security_interstitial_metrics_helper.h"
 #include "chrome/browser/interstitials/security_interstitial_page.h"
 #include "chrome/browser/safe_browsing/ui_manager.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "url/gurl.h"
 
 class MalwareDetails;
 class SafeBrowsingBlockingPageFactory;
 
 namespace base {
 class MessageLoop;
 }
 
 class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
  public:
   typedef SafeBrowsingUIManager::UnsafeResource UnsafeResource;
   typedef std::vector<UnsafeResource> UnsafeResourceList;
-  typedef std::map<content::WebContents*, UnsafeResourceList> UnsafeResourceMap;
 
   // Interstitial type, used in tests.
   static content::InterstitialPageDelegate::TypeID kTypeForTesting;
 
   ~SafeBrowsingBlockingPage() override;
 
   // Creates a blocking page. Use ShowBlockingPage if you don't need to access
   // the blocking page directly.
   static SafeBrowsingBlockingPage* CreateBlockingPage(
       SafeBrowsingUIManager* ui_manager,
@@ skipping 52 matching lines @@
   // Checks if we should even show the malware details option. For example, we
   // don't show it in incognito mode.
   bool CanShowMalwareDetailsOption();
 
   // Called when the insterstitial is going away. If there is a
   // pending malware details object, we look at the user's
   // preferences, and if the option to send malware details is
   // enabled, the report is scheduled to be sent on the |ui_manager_|.
   void FinishMalwareDetails(int64 delay_ms);
 
-  // A list of SafeBrowsingUIManager::UnsafeResource for a tab that the user
-  // should be warned about.  They are queued when displaying more than one
-  // interstitial at a time.
-  static UnsafeResourceMap* GetUnsafeResourcesMap();
-
   // Notifies the SafeBrowsingUIManager on the IO thread whether to proceed
   // or not for the |resources|.
   static void NotifySafeBrowsingUIManager(
       SafeBrowsingUIManager* ui_manager,
       const UnsafeResourceList& resources, bool proceed);
 
   // Returns true if the passed |unsafe_resources| is blocking the load of
   // the main page.
   static bool IsMainPageLoadBlocked(
       const UnsafeResourceList& unsafe_resources);
@@ skipping 55 matching lines @@
  public:
   virtual ~SafeBrowsingBlockingPageFactory() { }
 
   virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
       SafeBrowsingUIManager* ui_manager,
       content::WebContents* web_contents,
       const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) = 0;
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_