Issue 1183513003: Ignore queued Safe Browsing interstitial requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1183513003: Ignore queued Safe Browsing interstitial requests (Closed)

Created:
5 years, 6 months ago by felt

Modified:
5 years, 6 months ago

Reviewers:

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ignore queued Safe Browsing interstitial requests This makes the SBBP simply drop any incoming requests for displaying more interstitials. But if we just drop them then those resources can't load. So this approach is not the right one. Saving it for myself for posterity. BUG=

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -52 lines)			Patch
	M	chrome/browser/safe_browsing/safe_browsing_blocking_page.h	View		3 chunks	+5 lines, -11 lines	0 comments	Download
	M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View		5 chunks	+0 lines, -41 lines	0 comments	Download