GN: Avoid failing unconditionally on iOS due to the lack of a target for icudata

GN: Avoid failing unconditionally on iOS due to the lack of a target for icudata

R=brettw@chromium.org, dpranke@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/c3f79166089e5360c09e3053fce50e6e296c3204

[Chinmay, 2015-06-15 18:08:40]

chinmaygarde@google.com changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org, jshin@chromium.org

[Dirk Pranke, 2015-06-16 00:46:41]

lgtm

https://codereview.chromium.org/1183493003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1183493003/diff/1/BUILD.gn#newcode510
BUILD.gn:510: }
Please leave this as TODO(GYP): so that we can track all of the
transition-related things more easily. If you want to also have TODO(csg), feel
free to list both.

[Chinmay, 2015-06-16 01:09:47]

On 2015/06/16 at 00:46:41, dpranke wrote:
> lgtm
> 
> https://codereview.chromium.org/1183493003/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/1183493003/diff/1/BUILD.gn#newcode510
> BUILD.gn:510: }
> Please leave this as TODO(GYP): so that we can track all of the
transition-related things more easily. If you want to also have TODO(csg), feel
free to list both.

Done. Thanks

[Chinmay, 2015-06-16 01:09:55]

The CQ bit was checked by chinmaygarde@google.com

[Chinmay, 2015-06-16 01:09:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1183493003/#ps20001
(title: "Address CL concerns")

[commit-bot: I haz the power, 2015-06-16 01:11:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-16 01:11:03]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Dirk Pranke, 2015-06-16 01:26:35]

Brett, can I get an OWNERS approval for this?

[sdefresne, 2015-06-16 15:10:10]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2015-06-16 15:10:11]

https://codereview.chromium.org/1183493003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1183493003/diff/20001/BUILD.gn#newcode509
BUILD.gn:509: # the longer term, need to figure out how to use system ICU
Will we have to move all bundle resources to "executable" type targets? This may
proves problematic as Chrome for iOS already defines 15 targets and this will
only increase as more unit tests are upstreamed.

[Dirk Pranke, 2015-06-16 16:06:16]

https://codereview.chromium.org/1183493003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1183493003/diff/20001/BUILD.gn#newcode509
BUILD.gn:509: # the longer term, need to figure out how to use system ICU
On 2015/06/16 15:10:10, sdefresne wrote:
> Will we have to move all bundle resources to "executable" type targets? This
may
> proves problematic as Chrome for iOS already defines 15 targets and this will
> only increase as more unit tests are upstreamed. 

I expect we'll support a bundle() target type, but I'm not sure if that answers
your question?

[brettw, 2015-06-18 23:36:53]

lgtm

[Chinmay, 2015-06-18 23:37:12]

The CQ bit was checked by chinmaygarde@google.com

[commit-bot: I haz the power, 2015-06-18 23:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 23:41:06]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[eseidel, 2015-06-23 20:33:51]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2015-06-23 20:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 20:36:04]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Dirk Pranke, 2015-06-23 20:36:57]

I need to land this change manually for chinmay (I said I would do this, but
forgot :().

[Dirk Pranke, 2015-06-23 20:38:11]

Committed patchset #2 (id:20001) manually as
c3f79166089e5360c09e3053fce50e6e296c3204 (presubmit successful).

[Dirk Pranke, 2015-06-24 00:03:42]

On 2015/06/23 20:38:11, Dirk Pranke wrote:
> Committed patchset #2 (id:20001) manually as
> c3f79166089e5360c09e3053fce50e6e296c3204 (presubmit successful).

Note that this change will still need to be rolled into chromium; Chinmay, did
you want to post the CL for that?

[Chinmay, 2015-06-24 00:24:07]

On 2015/06/24 at 00:03:42, dpranke wrote:
> On 2015/06/23 20:38:11, Dirk Pranke wrote:
> > Committed patchset #2 (id:20001) manually as
> > c3f79166089e5360c09e3053fce50e6e296c3204 (presubmit successful).
> 
> Note that this change will still need to be rolled into chromium; Chinmay, did
you want to post the CL for that?

Thanks for reminding me. Will do.