Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: BUILD.gn

Issue 1183493003: GN: Avoid failing unconditionally on iOS due to the lack of a target for icudata (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Address CL concerns Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b80d1530f871a63d3ceb7cd1365c2db1428c5485..24fe92716c7dec50e0431a769956848c20e12c5d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -503,12 +503,11 @@ component("icuuc") {
# TODO(GYP) support use_system_icu.
if (icu_use_data_file) {
if (is_ios) {
- # TODO(GYP): Support mac resource bundle shown below.
- # 'link_settings': {
- # 'mac_bundle_resources': [
- # 'source/data/in/icudtl.dat',
- # ],
- # }
+ group("icudata") {
+ # TODO(GYP): Provide an empty group so that this target does not
+ # unconditionally fail. The dat file needs to be bundled separately. In
+ # the longer term, need to figure out how to use system ICU
sdefresne 2015/06/16 15:10:10 Will we have to move all bundle resources to "exec
Dirk Pranke 2015/06/16 16:06:16 I expect we'll support a bundle() target type, but
+ }
} else {
copy("icudata") {
if (is_android) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698