Refactor RenderTreeBuilder and expose special <dialog>

Refactor RenderTreeBuilder and expose special <dialog>

This refactors the RenderTreeBuilder so it's easier to see what's going on
inside the nextRenderer() and parentRenderer() methods. It also exposes that
<dialog> is trying to be special which I think is a mistake. Either dialogs
should always be in the top layer, or they should not have the ICB as their
containing block. We shouldn't be adding special cases for a particular
element to the core render tree construction code.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164662

[ojan, 2014-01-07 22:46:30]

lgtm

[commit-bot: I haz the power, 2014-01-07 22:47:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/118333005/80001

[commit-bot: I haz the power, 2014-01-07 22:47:52]

Failed to apply patch for Source/core/dom/Element.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Element.h
  Hunk #1 FAILED at 479.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/dom/Element.h.rej

Patch:       Source/core/dom/Element.h
Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index
eb69a1380f38f317c1b8cc8d3cd1ed911ab4d3cd..4d8fd10826efa8a57bd97ff5d20bf366f47f36c7
100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -479,8 +479,6 @@ public:
     // to event listeners, and prevents DOMActivate events from being sent at
all.
     virtual bool isDisabledFormControl() const { return false; }
 
-    virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const {
return isInTopLayer(); }
-
     virtual bool childShouldCreateRenderer(const Node& child) const;
     bool hasPendingResources() const;
     void setHasPendingResources();

[commit-bot: I haz the power, 2014-01-08 02:15:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/118333005/130001

[commit-bot: I haz the power, 2014-01-08 09:37:46]

Change committed as 164662