Chromium Code Reviews| Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java |
| diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java |
| index 8603fee37d7551945ec3933138b4b74ffb6b8d9a..6a1f4a30e15ab2d669853059cf1e22464cdcb605 100644 |
| --- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java |
| +++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/protocol/input/ChangeLiveBody.java |
| @@ -5,10 +5,13 @@ |
| package org.chromium.sdk.internal.v8native.protocol.input; |
| import org.chromium.sdk.internal.liveeditprotocol.LiveEditResult; |
| +import org.chromium.sdk.internal.protocolparser.EnumValueCondition; |
| import org.chromium.sdk.internal.protocolparser.JsonField; |
| import org.chromium.sdk.internal.protocolparser.JsonNullable; |
| import org.chromium.sdk.internal.protocolparser.JsonOptionalField; |
| +import org.chromium.sdk.internal.protocolparser.JsonOverrideField; |
| import org.chromium.sdk.internal.protocolparser.JsonSubtype; |
| +import org.chromium.sdk.internal.protocolparser.JsonSubtypeConditionCustom; |
| import org.chromium.sdk.internal.protocolparser.JsonType; |
| @JsonType |
| @@ -22,4 +25,36 @@ public interface ChangeLiveBody extends JsonSubtype<CommandResponseBody> { |
| @JsonOptionalField |
| Boolean stepin_recommended(); |
| + |
| + @JsonType |
| + interface CompileErrorDetails extends JsonSubtype<FailedCommandResponse.ErrorDetails> { |
| + @JsonOverrideField |
| + @JsonSubtypeConditionCustom(condition=TypeCondition.class) |
| + FailedCommandResponse.ErrorDetails.Type type(); |
| + |
| + String syntaxErrorMessage(); |
| + |
| + @JsonOptionalField |
| + Position position(); |
| + |
| + @JsonType |
| + interface Position { |
|
apavlov
2013/01/21 14:25:02
Sounds like an inappropriate name. This resembles
Peter Rybin
2013/01/21 16:01:32
Done.
|
| + PointPosition start(); |
| + PointPosition end(); |
| + } |
| + |
| + @JsonType |
| + interface PointPosition { |
|
apavlov
2013/01/21 14:25:02
Why "PointPosition"? A plain "Position" would work
Peter Rybin
2013/01/21 16:01:32
Done.
|
| + long position(); |
|
apavlov
2013/01/21 14:25:02
Is this actually an offset()? We should be very ca
Peter Rybin
2013/01/21 16:01:32
Done.
|
| + long line(); |
| + long column(); |
| + } |
| + |
| + |
| + class TypeCondition extends EnumValueCondition<FailedCommandResponse.ErrorDetails.Type> { |
| + public TypeCondition() { |
| + super(FailedCommandResponse.ErrorDetails.Type.LIVEEDIT_COMPILE_ERROR); |
| + } |
| + } |
| + } |
| } |