Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1183213007: Fix offscreen rendering on iOS by not assuming that the default window bound framebuffer is 0 (Closed)

Created:
5 years, 6 months ago by Chinmay
Modified:
5 years, 6 months ago
Reviewers:
iansf, abarth-chromium
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix offscreen rendering on iOS by not assuming that the default window bound framebuffer is 0 BUG= R=iansf@google.com Committed: https://chromium.googlesource.com/external/mojo/+/dc370aa7a579af669d76123d8bd1dffbdc191483

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M sky/shell/gpu/ganesh_surface.h View 1 chunk +5 lines, -3 lines 0 comments Download
M sky/shell/gpu/ganesh_surface.cc View 1 chunk +4 lines, -1 line 0 comments Download
M sky/shell/gpu/rasterizer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/gpu/rasterizer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_ios.h View 1 chunk +1 line, -0 lines 1 comment Download
M ui/gl/gl_surface_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Chinmay
5 years, 6 months ago (2015-06-16 00:56:54 UTC) #2
iansf
https://codereview.chromium.org/1183213007/diff/1/ui/gl/gl_surface_ios.h File ui/gl/gl_surface_ios.h (right): https://codereview.chromium.org/1183213007/diff/1/ui/gl/gl_surface_ios.h#newcode20 ui/gl/gl_surface_ios.h:20: unsigned int GetBackingFrameBufferObject() override; Is there a corresponding change ...
5 years, 6 months ago (2015-06-16 01:21:27 UTC) #3
Chinmay
On 2015/06/16 at 01:21:27, iansf wrote: > https://codereview.chromium.org/1183213007/diff/1/ui/gl/gl_surface_ios.h > File ui/gl/gl_surface_ios.h (right): > > https://codereview.chromium.org/1183213007/diff/1/ui/gl/gl_surface_ios.h#newcode20 ...
5 years, 6 months ago (2015-06-16 01:25:55 UTC) #4
iansf
lgtm lgtm
5 years, 6 months ago (2015-06-16 16:50:01 UTC) #5
Chinmay
5 years, 6 months ago (2015-06-16 16:51:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc370aa7a579af669d76123d8bd1dffbdc191483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698