cc: Do not request redraw on commit when impl-side painting

cc/scheduler_state_machine.cc

Index: cc/scheduler_state_machine.cc
diff --git a/cc/scheduler_state_machine.cc b/cc/scheduler_state_machine.cc
index f9d8cbc8f5b90b834ab8a1102f5de8b3b9384221..60a1ce9a3a1dffb0892ebf0fc45e3f64660f43bf 100644
--- a/cc/scheduler_state_machine.cc
+++ b/cc/scheduler_state_machine.cc
@@ -6,11 +6,13 @@
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
+#include "cc/layer_tree_settings.h"
 
 namespace cc {
 
-SchedulerStateMachine::SchedulerStateMachine()
-    : m_commitState(COMMIT_STATE_IDLE)
+SchedulerStateMachine::SchedulerStateMachine(const LayerTreeSettings &layerTreeSettings)

[nduca, 2013/01/15 01:54:54]

I'm not liking the machine having access to all the settings. This means that
all of a sudden, its possible for the state machine to branch on just about  a
zillion things. Is it possible to just make a simple

struct SchedulerSettings {
   bool implSidePainting
}

that you pass in? You've done the hard work --- you shold be able to edit the
raw patch for this changelist in your editor, replacing LayerTreeSettings with
SchedulerSettings. Then reset --hard origin/master, git patch -p1 <
~/edited_patch.patch and you should be good to go.

[brianderson, 2013/01/15 02:01:56]

Sounds good.

+    : m_layerTreeSettings(layerTreeSettings)
+    , m_commitState(COMMIT_STATE_IDLE)
     , m_currentFrameNumber(0)
     , m_lastFrameNumberWhereDrawWasCalled(-1)
     , m_lastFrameNumberWhereTreeActivationAttempted(-1)
@@ -209,7 +211,8 @@ void SchedulerStateMachine::updateState(Action action)
             m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_FORCED_DRAW;
         else
             m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_DRAW;
-        m_needsRedraw = true;
+        if (!m_layerTreeSettings.implSidePainting)
+            m_needsRedraw = true;
         if (m_drawIfPossibleFailed)
             m_lastFrameNumberWhereDrawWasCalled = -1;