cc: Do not request redraw on commit when impl-side painting

cc/scheduler_state_machine.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/scheduler_state_machine.h"
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
+#include "cc/layer_tree_settings.h"
 
 namespace cc {
 
-SchedulerStateMachine::SchedulerStateMachine()
-    : m_commitState(COMMIT_STATE_IDLE)
+SchedulerStateMachine::SchedulerStateMachine(const LayerTreeSettings &layerTreeSettings)

[nduca, 2013/01/15 01:54:54]

I'm not liking the machine having access to all the settings. This means that
all of a sudden, its possible for the state machine to branch on just about  a
zillion things. Is it possible to just make a simple

struct SchedulerSettings {
   bool implSidePainting
}

that you pass in? You've done the hard work --- you shold be able to edit the
raw patch for this changelist in your editor, replacing LayerTreeSettings with
SchedulerSettings. Then reset --hard origin/master, git patch -p1 <
~/edited_patch.patch and you should be good to go.

[brianderson, 2013/01/15 02:01:56]

Sounds good.

+    : m_layerTreeSettings(layerTreeSettings)
+    , m_commitState(COMMIT_STATE_IDLE)
     , m_currentFrameNumber(0)
     , m_lastFrameNumberWhereDrawWasCalled(-1)
     , m_lastFrameNumberWhereTreeActivationAttempted(-1)
     , m_consecutiveFailedDraws(0)
     , m_maximumNumberOfFailedDrawsBeforeDrawIsForced(3)
     , m_needsRedraw(false)
     , m_needsForcedRedraw(false)
     , m_needsForcedRedrawAfterNextCommit(false)
     , m_needsCommit(false)
     , m_needsForcedCommit(false)
@@ skipping 178 matching lines @@
         m_commitState = COMMIT_STATE_FRAME_IN_PROGRESS;
         m_needsCommit = false;
         m_needsForcedCommit = false;
         return;
 
     case ACTION_COMMIT:
         if (m_expectImmediateBeginFrame)
             m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_FORCED_DRAW;
         else
             m_commitState = COMMIT_STATE_WAITING_FOR_FIRST_DRAW;
-        m_needsRedraw = true;
+        if (!m_layerTreeSettings.implSidePainting)
+            m_needsRedraw = true;
         if (m_drawIfPossibleFailed)
             m_lastFrameNumberWhereDrawWasCalled = -1;
 
         if (m_needsForcedRedrawAfterNextCommit) {
             m_needsForcedRedrawAfterNextCommit = false;
             m_needsForcedRedraw = true;
         }
 
         m_textureState = LAYER_TEXTURE_STATE_ACQUIRED_BY_IMPL_THREAD;
         return;
@@ skipping 149 matching lines @@
     m_outputSurfaceState = OUTPUT_SURFACE_ACTIVE;
     setNeedsCommit();
 }
 
 void SchedulerStateMachine::setMaximumNumberOfFailedDrawsBeforeDrawIsForced(int numDraws)
 {
     m_maximumNumberOfFailedDrawsBeforeDrawIsForced = numDraws;
 }
 
 }  // namespace cc