Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182983002: Rename widgets/wrappers.dart to widgets/basic.dart (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename widgets/wrappers.dart to widgets/basic.dart Although the basic widgets are wrappers, that's an implementation detail and shouldn't be encoded in the name of the library. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/302dbc7a1b9c35a90fb221ce94a35d880bc308b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -421 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_row.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/container.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/hello_widgets.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/home.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/editing2/editable_text.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/editing2/input.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/animated_component.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sky/sdk/lib/framework/widgets/basic.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/sdk/lib/framework/widgets/button_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/checkbox.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/drawer_header.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/fixed_height_scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/floating_action_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/icon.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/icon_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/ink_well.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/material.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/modal_overlay.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/popup_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/popup_menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/radio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/raised_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/widgets/tool_bar.dart View 1 chunk +1 line, -1 line 0 comments Download
D sky/sdk/lib/framework/widgets/wrappers.dart View 1 chunk +0 lines, -390 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-13 05:16:42 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as 302dbc7a1b9c35a90fb221ce94a35d880bc308b5 (presubmit successful).
5 years, 6 months ago (2015-06-13 05:16:54 UTC) #2
Hixie
5 years, 6 months ago (2015-06-15 17:38:11 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698