Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: utils/testrunner/standard_test_runner.dart

Issue 11829045: Cleaning up unittest configurations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/unittest/lib/vm_config.dart ('K') | « pkg/unittest/test/unittest_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/testrunner/standard_test_runner.dart
diff --git a/utils/testrunner/standard_test_runner.dart b/utils/testrunner/standard_test_runner.dart
index 981d95c7c840ecd4a6fc9d4fcfc16d58e8d979ae..1b4195c15b4740822af830e0a6b8063799fcdad3 100644
--- a/utils/testrunner/standard_test_runner.dart
+++ b/utils/testrunner/standard_test_runner.dart
@@ -115,11 +115,8 @@ class TestRunnerConfiguration extends unittest.Configuration {
}
}
- void onDone(int passed, int failed, int errors,
- List<unittest.TestCase> results,
- String uncaughtError) {
- var success = (passed > 0 && failed == 0 && errors == 0 &&
- uncaughtError == null);
+ void onSummary(int passed, int failed, int errors,
+ List<unittest.TestCase> results, String uncaughtError) {
if (!immediate) {
for (final testCase in results) {
dumpTestResult('$testfile ', testCase);
@@ -128,6 +125,9 @@ class TestRunnerConfiguration extends unittest.Configuration {
if (summarize) {
printSummary(passed, failed, errors, uncaughtError);
}
+ }
+
+ void onDone(bool success) {
if (notifyDone != null) {
notifyDone(success ? 0 : -1);
}
@@ -195,8 +195,8 @@ class TestRunnerChildConfiguration extends unittest.Configuration {
get name => 'Test runner child configuration';
get autoStart => false;
- void onDone(int passed, int failed, int errors,
- List<unittest.TestCase> results, String uncaughtError) {
+ void onSummary(int passed, int failed, int errors,
+ List<unittest.TestCase> results, String uncaughtError) {
unittest.TestCase test = results[0];
parentPort.send([test.result, test.runningTime.inMilliseconds,
test.message, test.stackTrace]);
« pkg/unittest/lib/vm_config.dart ('K') | « pkg/unittest/test/unittest_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698