Cleaning up unittest configurations

utils/testrunner/standard_test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(gram): dart2js is not handling 'part of' properly yet; when it does
 // uncomment this.
 //part of test_controller;
 
 /** Path to DRT executable. */
 String drt;
@@ skipping 97 matching lines @@
     } else if (failed == 0 && errors == 0 && uncaughtError == null) {
       tprint('$testfile: All $passed tests passed.');
     } else {
       if (uncaughtError != null) {
         tprint('$testfile: Top-level uncaught error: $uncaughtError');
       }
       tprint('$testfile: $passed PASSED, $failed FAILED, $errors ERRORS');
     }
   }
 
-  void onDone(int passed, int failed, int errors,
-              List<unittest.TestCase> results,
-              String uncaughtError) {
-    var success = (passed > 0 && failed == 0 && errors == 0 &&
-        uncaughtError == null);
+  void onSummary(int passed, int failed, int errors,
+      List<unittest.TestCase> results, String uncaughtError) {
     if (!immediate) {
       for (final testCase in results) {
         dumpTestResult('$testfile ', testCase);
       }
     }
     if (summarize) {
       printSummary(passed, failed, errors, uncaughtError);
     }
+  }
+
+  void onDone(bool success) {
     if (notifyDone != null) {
       notifyDone(success ? 0 : -1);
     }
   }
 }
 
 // Support for listing tests and groups. We use a minimal config.
 class MinimalTestRunnerConfiguration extends unittest.Configuration {
   get name => 'Minimal test runner configuration';
   get autoStart => false;
@@ skipping 47 matching lines @@
     notifyDone(0);
   }
 }
 
 // Support for running in isolates.
 
 class TestRunnerChildConfiguration extends unittest.Configuration {
   get name => 'Test runner child configuration';
   get autoStart => false;
 
-  void onDone(int passed, int failed, int errors,
-              List<unittest.TestCase> results, String uncaughtError) {
+  void onSummary(int passed, int failed, int errors,
+      List<unittest.TestCase> results, String uncaughtError) {
     unittest.TestCase test = results[0];
     parentPort.send([test.result, test.runningTime.inMilliseconds,
                      test.message, test.stackTrace]);
   }
 }
 
 var parentPort;
 runChildTest() {
   port.receive((testName, sendport) {
     parentPort = sendport;
@@ skipping 66 matching lines @@
 }
 
 process(testMain, action) {
   unittest.groupSep = '###';
   unittest.configure(new TestRunnerConfiguration());
   unittest.group('', testMain);
   // Do any user-specified test filtering.
   unittest.filterTests(filterTest);
   action();
 }