Cleaning up unittest configurations

pkg/unittest/lib/compact_vm_config.dart

Index: pkg/unittest/lib/compact_vm_config.dart
diff --git a/pkg/unittest/lib/compact_vm_config.dart b/pkg/unittest/lib/compact_vm_config.dart
index 55831564456def06989ac71b31a601c3e4326060..0a4080b18ceab2cabddeabe425268ee1e6359450 100644
--- a/pkg/unittest/lib/compact_vm_config.dart
+++ b/pkg/unittest/lib/compact_vm_config.dart
@@ -11,7 +11,7 @@
 library compact_vm_config;
 
 import 'dart:io';
-import 'package:unittest/unittest.dart';
+import 'unittest.dart';
 
 const String _GREEN = '\u001b[32m';
 const String _RED = '\u001b[31m';
@@ -60,7 +60,7 @@ class CompactVMConfiguration extends Configuration {
     return str.split("\n").mappedBy((line) => "  $line").join("\n");
   }
 
-  void onDone(int passed, int failed, int errors, List<TestCase> results,
+  void onSummary(int passed, int failed, int errors, List<TestCase> results,
       String uncaughtError) {
     var success = false;
     if (passed == 0 && failed == 0 && errors == 0) {
@@ -77,8 +77,14 @@ class CompactVMConfiguration extends Configuration {
       }
       print('$passed PASSED, $failed FAILED, $errors ERRORS');
     }
+  }
 
-    if (!success) exit(1);
+  void onDone(bool success) {
+    try {
+      super.onDone(success);
+    } on Exception catch(ex) {

[Jennifer Messerly, 2013/01/10 02:31:32]

should this just be a raw catch -- or do we know for sure it won't be an Error?

[Siggi Cherem (dart-lang), 2013/01/10 02:44:49]

Done (see changes in vm_config). Technically we know it is Exception because
that's what we throw in config.dart, but using a raw catch works too.

+      exit(1);

[Jennifer Messerly, 2013/01/10 02:31:32]

out of curiousity -- why do we need the explicit "exit(1)" if the base class
doesn't have it?

[Siggi Cherem (dart-lang), 2013/01/10 02:44:49]

Configuration (the base class I was using) is meant to work everywhere (drt, vm,
etc), so we couldn't use 'exit' there. Instead, Configuration throws an
exception as a way to exit with an error code.

Failure runs always have a stack trace from Configuration, so we used this catch
as a way of getting rid of it in the vm. I was doing this here and in
VMConfiguration, which made me realize that the base class for this compact
configuration should be VMConfiguration instead. I just updated the code
accordingly.

+    }
   }
 
   int _lastLength = 0;
@@ -166,6 +172,8 @@ class CompactVMConfiguration extends Configuration {
     }
     return '...$res';
   }
+
+  void notifyController(String msg) {}
 }
 
 void useCompactVMConfiguration() {