Cleaning up unittest configurations

pkg/unittest/lib/compact_vm_config.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A test configuration that generates a compact 1-line progress bar. The bar is
  * updated in-place before and after each test is executed. If all test pass,
  * you should only see a couple lines in the terminal. If a test fails, the
  * failure is shown and the progress bar continues to be updated below it.
  */
 library compact_vm_config;
 
 import 'dart:io';
-import 'package:unittest/unittest.dart';
+import 'unittest.dart';
 
 const String _GREEN = '\u001b[32m';
 const String _RED = '\u001b[31m';
 const String _NONE = '\u001b[0m';
 const int MAX_LINE = 80;
 
 class CompactVMConfiguration extends Configuration {
   Date _start;
   int _pass = 0;
   int _fail = 0;
@@ skipping 28 matching lines @@
       if (test.stackTrace != null && test.stackTrace != '') {
         print(_indent(test.stackTrace));
       }
     }
   }
 
   String _indent(String str) {
     return str.split("\n").mappedBy((line) => "  $line").join("\n");
   }
 
-  void onDone(int passed, int failed, int errors, List<TestCase> results,
+  void onSummary(int passed, int failed, int errors, List<TestCase> results,
       String uncaughtError) {
     var success = false;
     if (passed == 0 && failed == 0 && errors == 0) {
       print('\nNo tests ran.');
     } else if (failed == 0 && errors == 0 && uncaughtError == null) {
       _progressLine(_start, _pass, _fail, 'All tests pass', _GREEN);
       print('\nAll $passed tests passed.');
       success = true;
     } else {
       _progressLine(_start, _pass, _fail, 'Some tests fail', _RED);
       print('');
       if (uncaughtError != null) {
         print('Top-level uncaught error: $uncaughtError');
       }
       print('$passed PASSED, $failed FAILED, $errors ERRORS');
     }
+  }
 
-    if (!success) exit(1);
+  void onDone(bool success) {
+    try {
+      super.onDone(success);
+    } on Exception catch(ex) {

[Jennifer Messerly, 2013/01/10 02:31:32]

should this just be a raw catch -- or do we know for sure it won't be an Error?

[Siggi Cherem (dart-lang), 2013/01/10 02:44:49]

Done (see changes in vm_config). Technically we know it is Exception because
that's what we throw in config.dart, but using a raw catch works too.

+      exit(1);

[Jennifer Messerly, 2013/01/10 02:31:32]

out of curiousity -- why do we need the explicit "exit(1)" if the base class
doesn't have it?

[Siggi Cherem (dart-lang), 2013/01/10 02:44:49]

Configuration (the base class I was using) is meant to work everywhere (drt, vm,
etc), so we couldn't use 'exit' there. Instead, Configuration throws an
exception as a way to exit with an error code.

Failure runs always have a stack trace from Configuration, so we used this catch
as a way of getting rid of it in the vm. I was doing this here and in
VMConfiguration, which made me realize that the base class for this compact
configuration should be VMConfiguration instead. I just updated the code
accordingly.

+    }
   }
 
   int _lastLength = 0;
 
   final int _nonVisiblePrefix = 1 + _GREEN.length + _NONE.length;
 
   void _progressLine(Date startTime, int passed, int failed, String message,
       [String color = _NONE]) {
     var duration = (new Date.now()).difference(startTime);
     var buffer = new StringBuffer();
@@ skipping 67 matching lines @@
 
     // Otherwise truncate to return the trailing text, but attempt to start at
     // the beginning of a word.
     var res = text.substring(text.length - maxLength + 4);
     var firstSpace = res.indexOf(' ');
     if (firstSpace > 0) {
       res = res.substring(firstSpace);
     }
     return '...$res';
   }
+
+  void notifyController(String msg) {}
 }
 
 void useCompactVMConfiguration() {
   configure(new CompactVMConfiguration());
 }