[Spellcheck] Turning spelling service on by default. Adding command line flag to turn spelling serv…

chrome/common/chrome_switches.cc

Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index 8119bd242b460504b6c277977f82c78bb399c648..5d49213224d53a0bf7ee8743ff5ec4fd2b1c3767 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -1322,9 +1322,9 @@ const char kUseGpuInTests[] = "use-gpu-in-tests";
 // testing flag.
 const char kUseSpdy[]                       = "use-spdy";
 
-// Enables use of the spelling web service. This will only work if asynchronous
-// spell checking is not disabled.
-const char kUseSpellingService[]            = "use-spelling-service";
+// Disables use of the spelling web service and only provides suggestions.
+// This will only work if asynchronous spell checking is not disabled.
+const char kUseSpellingSuggestions[]            = "use-spelling-suggestions";

[groby-ooo-7-16, 2013/01/10 01:00:56]

So we _always_ get suggestions? Shouldn't this then be disable-spelling-service?

[rpetterson, 2013/01/10 01:06:10]

If you want to disable the spelling service, uncheck "Ask Google for
Suggestions" (AGFS). I see it the following way:

If AGFS is on, we use the spelling service by default
If AGFS is on, but the user has passed the use suggetions flag, we revert to
suggestions.

There is another pref (kUseSpellCheckSpellingService) which might be what you're
thinking of? I haven't touched that one.

 
 // Sets the maximum SPDY sessions per domain.
 const char kMaxSpdySessionsPerDomain[]      = "max-spdy-sessions-per-domain";