[Spellcheck] Turning spelling service on by default. Adding command line flag to turn spelling serv…

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 1304 matching lines @@
 // Runs un-installation steps that were done by chrome first-run.
 const char kUninstall[]                     = "uninstall";
 
 // Use hardware gpu, if available, for tests.
 const char kUseGpuInTests[] = "use-gpu-in-tests";
 
 // Uses Spdy for the transport protocol instead of HTTP. This is a temporary
 // testing flag.
 const char kUseSpdy[]                       = "use-spdy";
 
-// Enables use of the spelling web service. This will only work if asynchronous
-// spell checking is not disabled.
-const char kUseSpellingService[]            = "use-spelling-service";
+// Disables use of the spelling web service and only provides suggestions.
+// This will only work if asynchronous spell checking is not disabled.
+const char kUseSpellingSuggestions[]            = "use-spelling-suggestions";

[groby-ooo-7-16, 2013/01/10 01:00:56]

So we _always_ get suggestions? Shouldn't this then be disable-spelling-service?

[rpetterson, 2013/01/10 01:06:10]

If you want to disable the spelling service, uncheck "Ask Google for
Suggestions" (AGFS). I see it the following way:

If AGFS is on, we use the spelling service by default
If AGFS is on, but the user has passed the use suggetions flag, we revert to
suggestions.

There is another pref (kUseSpellCheckSpellingService) which might be what you're
thinking of? I haven't touched that one.

 
 // Sets the maximum SPDY sessions per domain.
 const char kMaxSpdySessionsPerDomain[]      = "max-spdy-sessions-per-domain";
 
 // Sets the maximum concurrent streams over a SPDY session.
 const char kMaxSpdyConcurrentStreams[]      = "max-spdy-concurrent-streams";
 
 // Specifies the user data directory, which is where the browser will look for
 // all of its state.
 const char kUserDataDir[]                   = "user-data-dir";
@@ skipping 283 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead, please
 // put them in alphabetical order above, or in order inside the appropriate
 // ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches