Issue 118283002: Suppress questionable gpu errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 118283002: Suppress questionable gpu errors (Closed)

Created:
7 years ago by robertphillips

Modified:
7 years ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

These errors appear consistently on the valgrind bot but I cannot reproduce them locally. Suppress for now.

Patch Set 1 #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -24 lines)			Patch
M	gm/valgrind.supp	View	1 chunk	+44 lines, -8 lines	0 comments	Download
M	tests/valgrind.supp	View	1 chunk	+44 lines, -8 lines	0 comments	Download
M	tools/valgrind.supp	View	1 chunk	+44 lines, -8 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM with suggestion. https://codereview.chromium.org/118283002/diff/1/tools/valgrind.supp File tools/valgrind.supp (right): https://codereview.chromium.org/118283002/diff/1/tools/valgrind.supp#newcode90 tools/valgrind.supp:90: { Maybe add comments to indicate ...

7 years ago (2013-12-18 15:01:18 UTC) #2

robertphillips

7 years ago (2013-12-18 17:29:08 UTC) #3

Message was sent while issue was closed.

committed as r12743

https://codereview.chromium.org/118283002/diff/1/tools/valgrind.supp
File tools/valgrind.supp (right):

https://codereview.chromium.org/118283002/diff/1/tools/valgrind.supp#newcode90
tools/valgrind.supp:90: {
On 2013/12/18 15:01:18, borenet wrote:
> Maybe add comments to indicate that we're not sure whether or not these are
real
> issues but can't reproduce them?

Done.

Expand Messages | Collapse Messages