Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: src/effects/SkLumaColorFilter.cpp

Issue 1182813002: Don't leak fragment processor in SkColorFilter::asFragmentProcessors implementations. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/effects/SkColorMatrixFilter.cpp ('k') | src/effects/SkTableColorFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkLumaColorFilter.h" 8 #include "SkLumaColorFilter.h"
9 9
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 } 119 }
120 }; 120 };
121 121
122 bool SkLumaColorFilter::asFragmentProcessors(GrContext*, 122 bool SkLumaColorFilter::asFragmentProcessors(GrContext*,
123 SkTDArray<GrFragmentProcessor*>* ar ray) const { 123 SkTDArray<GrFragmentProcessor*>* ar ray) const {
124 124
125 GrFragmentProcessor* frag = LumaColorFilterEffect::Create(); 125 GrFragmentProcessor* frag = LumaColorFilterEffect::Create();
126 if (frag) { 126 if (frag) {
127 if (array) { 127 if (array) {
128 *array->append() = frag; 128 *array->append() = frag;
129 } else {
130 frag->unref();
131 SkDEBUGCODE(frag = NULL;)
Noel Gordon 2015/06/12 17:51:00 That wink at <eol> is interesting ;)
129 } 132 }
130 return true; 133 return true;
131 } 134 }
132 return false; 135 return false;
133 } 136 }
134 #endif 137 #endif
OLDNEW
« no previous file with comments | « src/effects/SkColorMatrixFilter.cpp ('k') | src/effects/SkTableColorFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698