Remove IPC code for old methods.

Remove IPC code for old methods.

This is cleanup from a number of steps of a larger refactoring.

In particular, we've gotten rid of backend Object Stores and Indexes,
and migrated a number of methods into the backend database object.

BUG=156244
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176385

[alecflett, 2013-01-10 21:56:11]

jsbell / tsepez / tony - mind reviews on your respective areas? (tony, yours is
webkit/support )

Thanks!

[Tom Sepez, 2013-01-10 22:20:22]

Rubberstamp LGTM on deleting code.

[jsbell, 2013-01-10 22:23:02]

lgtm with one nit

https://chromiumcodereview.appspot.com/11828054/diff/1/webkit/support/test_we...
File webkit/support/test_webkit_platform_support.cc (right):

https://chromiumcodereview.appspot.com/11828054/diff/1/webkit/support/test_we...
webkit/support/test_webkit_platform_support.cc:377: factory_->open(name,
version, 1, callbacks, databaseCallbacks, origin, frame,
Nit: line length

[tony, 2013-01-10 22:23:43]

webkit/support lgtm with jsbell's suggestion.

[commit-bot: I haz the power, 2013-01-10 23:28:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002

[commit-bot: I haz the power, 2013-01-10 23:28:34]

Presubmit check for 11828054-4002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content

Presubmit checks took 1.2s to calculate.

[alecflett2, 2013-01-11 00:00:50]

Darin, mind a quick review for content/content_common.gypi?

[darin (slow to review), 2013-01-11 00:48:06]

LGTM

https://codereview.chromium.org/11828054/diff/4002/content/common/indexed_db/...
File content/common/indexed_db/indexed_db_dispatcher_unittest.cc (right):

https://codereview.chromium.org/11828054/diff/4002/content/common/indexed_db/...
content/common/indexed_db/indexed_db_dispatcher_unittest.cc:31: const int32
ipc_dummy_id = -1;
nit: constants are usually formatted as kFooBar

[commit-bot: I haz the power, 2013-01-11 03:08:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002

[commit-bot: I haz the power, 2013-01-11 13:38:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002

[commit-bot: I haz the power, 2013-01-11 13:46:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002

[commit-bot: I haz the power, 2013-01-11 13:55:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002

[commit-bot: I haz the power, 2013-01-11 16:17:50]

Failed to apply patch for
content/common/indexed_db/proxy_webidbtransaction_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/common/indexed_db/proxy_webidbtransaction_impl.cc
  Hunk #1 FAILED at 6.
  1 out of 2 hunks FAILED -- saving rejects to file
content/common/indexed_db/proxy_webidbtransaction_impl.cc.rej

Patch:       content/common/indexed_db/proxy_webidbtransaction_impl.cc
Index: content/common/indexed_db/proxy_webidbtransaction_impl.cc
diff --git a/content/common/indexed_db/proxy_webidbtransaction_impl.cc
b/content/common/indexed_db/proxy_webidbtransaction_impl.cc
index
dfed16537cf37c76ba11dd96f294e3e48b2d5015..f0a256a7706ad9a321763b060693ec558b07aba5
100644
--- a/content/common/indexed_db/proxy_webidbtransaction_impl.cc
+++ b/content/common/indexed_db/proxy_webidbtransaction_impl.cc
@@ -6,9 +6,7 @@
 
 #include "content/common/indexed_db/indexed_db_messages.h"
 #include "content/common/indexed_db/indexed_db_dispatcher.h"
-#include "content/common/indexed_db/proxy_webidbobjectstore_impl.h"
 #include "content/common/child_thread.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBObjectStore.h"
 #include
"third_party/WebKit/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h"
 #include
"third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
 
@@ -32,18 +30,6 @@
RendererWebIDBTransactionImpl::~RendererWebIDBTransactionImpl() {
       ipc_transaction_id_));
 }
 
-WebIDBObjectStore* RendererWebIDBTransactionImpl::objectStore(
-    long long object_store_id,
-    WebKit::WebExceptionCode& ec) {
-  int ipc_object_store_id;
-  IndexedDBDispatcher::Send(
-      new IndexedDBHostMsg_TransactionObjectStore(
-          ipc_transaction_id_, object_store_id, &ipc_object_store_id, &ec));
-  if (!object_store_id)
-    return NULL;
-  return new RendererWebIDBObjectStoreImpl(ipc_object_store_id);
-}
-
 void RendererWebIDBTransactionImpl::commit() {
   IndexedDBDispatcher::Send(new IndexedDBHostMsg_TransactionCommit(
       ipc_transaction_id_));

[commit-bot: I haz the power, 2013-01-11 17:40:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/12002