Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(74)

Issue 11828054: Remove IPC code for old methods. (Closed)

Created:
7 years, 10 months ago by alecflett
Modified:
7 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove IPC code for old methods. This is cleanup from a number of steps of a larger refactoring. In particular, we've gotten rid of backend Object Stores and Indexes, and migrated a number of methods into the backend database object. BUG=156244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176385

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix line length #

Total comments: 1

Patch Set 3 : Fix merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1573 lines) Patch
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 6 chunks +0 lines, -96 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 13 chunks +0 lines, -526 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.h View 2 chunks +0 lines, -85 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 2 chunks +0 lines, -203 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher_unittest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 6 chunks +0 lines, -138 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.h View 2 chunks +0 lines, -11 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.cc View 1 2 3 chunks +0 lines, -35 lines 0 comments Download
D content/common/indexed_db/proxy_webidbindex_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/common/indexed_db/proxy_webidbindex_impl.cc View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
D content/common/indexed_db/proxy_webidbobjectstore_impl.h View 1 chunk +0 lines, -91 lines 0 comments Download
D content/common/indexed_db/proxy_webidbobjectstore_impl.cc View 1 2 1 chunk +0 lines, -213 lines 0 comments Download
M content/common/indexed_db/proxy_webidbtransaction_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/indexed_db/proxy_webidbtransaction_impl.cc View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
alecflett
jsbell / tsepez / tony - mind reviews on your respective areas? (tony, yours is ...
7 years, 10 months ago (2013-01-10 21:56:11 UTC) #1
Tom Sepez
Rubberstamp LGTM on deleting code.
7 years, 10 months ago (2013-01-10 22:20:22 UTC) #2
jsbell
lgtm with one nit https://chromiumcodereview.appspot.com/11828054/diff/1/webkit/support/test_webkit_platform_support.cc File webkit/support/test_webkit_platform_support.cc (right): https://chromiumcodereview.appspot.com/11828054/diff/1/webkit/support/test_webkit_platform_support.cc#newcode377 webkit/support/test_webkit_platform_support.cc:377: factory_->open(name, version, 1, callbacks, databaseCallbacks, ...
7 years, 10 months ago (2013-01-10 22:23:02 UTC) #3
tony
webkit/support lgtm with jsbell's suggestion.
7 years, 10 months ago (2013-01-10 22:23:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002
7 years, 10 months ago (2013-01-10 23:28:22 UTC) #5
commit-bot: I haz the power
Presubmit check for 11828054-4002 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-01-10 23:28:34 UTC) #6
alecflett2
Darin, mind a quick review for content/content_common.gypi?
7 years, 10 months ago (2013-01-11 00:00:50 UTC) #7
darin (slow to review)
LGTM https://codereview.chromium.org/11828054/diff/4002/content/common/indexed_db/indexed_db_dispatcher_unittest.cc File content/common/indexed_db/indexed_db_dispatcher_unittest.cc (right): https://codereview.chromium.org/11828054/diff/4002/content/common/indexed_db/indexed_db_dispatcher_unittest.cc#newcode31 content/common/indexed_db/indexed_db_dispatcher_unittest.cc:31: const int32 ipc_dummy_id = -1; nit: constants are ...
7 years, 10 months ago (2013-01-11 00:48:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002
7 years, 10 months ago (2013-01-11 03:08:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002
7 years, 10 months ago (2013-01-11 13:38:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002
7 years, 10 months ago (2013-01-11 13:46:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11828054/4002
7 years, 10 months ago (2013-01-11 13:55:28 UTC) #12
commit-bot: I haz the power
Failed to apply patch for content/common/indexed_db/proxy_webidbtransaction_impl.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 10 months ago (2013-01-11 16:17:50 UTC) #13
commit-bot: I haz the power
7 years, 10 months ago (2013-01-11 17:40:40 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698