Issue 11828010: NaCl: Fix '*' spacing style in nacl_helper_linux.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11828010: NaCl: Fix '*' spacing style in nacl_helper_linux.cc (Closed)

Created:
7 years, 11 months ago by Mark Seaborn

Modified:
7 years, 11 months ago

Reviewers:
Roland McGrath

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Fix '*' spacing style in nacl_helper_linux.cc Use the Chrome style rather than the NaCl style. Also remove "struct" keywords and use a C++-style cast. BUG=none TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175854

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove "struct" #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	chrome/nacl/nacl_helper_linux.cc	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roland McGrath

lgtm https://codereview.chromium.org/11828010/diff/1/chrome/nacl/nacl_helper_linux.cc File chrome/nacl/nacl_helper_linux.cc (right): https://codereview.chromium.org/11828010/diff/1/chrome/nacl/nacl_helper_linux.cc#newcode155 chrome/nacl/nacl_helper_linux.cc:155: struct r_debug* bootstrap_r_debug = It is probably style-correct ...

7 years, 11 months ago (2013-01-09 18:55:12 UTC) #2

commit-bot: I haz the power

7 years, 11 months ago (2013-01-09 19:17:49 UTC) #3

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages