NaCl: Fix '*' spacing style in nacl_helper_linux.cc

chrome/nacl/nacl_helper_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A mini-zygote specifically for Native Client.
 
 #include "chrome/common/nacl_helper_linux.h"
 
 #include <errno.h>
 #include <link.h>
@@ skipping 127 matching lines @@
 // structure.  The debugger will look for that symbol by name to
 // discover the addresses of key dynamic linker data structures.
 // Since all it knows about is the original main executable, which
 // is the bootstrap program, it finds the symbol defined there.  The
 // dynamic linker's structure is somewhere else, but it is filled in
 // after initialization.  The parts that really matter to the
 // debugger never change.  So we just copy the contents of the
 // dynamic linker's structure into the address provided by the option.
 // Hereafter, if someone attaches a debugger (or examines a core dump),
 // the debugger will find all the symbols in the normal way.
-static void CheckRDebug(char *argv0) {
+static void CheckRDebug(char* argv0) {
   std::string r_debug_switch_value =
       CommandLine::ForCurrentProcess()->GetSwitchValueASCII(kNaClHelperRDebug);
   if (!r_debug_switch_value.empty()) {
-    char *endp;
+    char* endp;
     uintptr_t r_debug_addr = strtoul(r_debug_switch_value.c_str(), &endp, 0);
     if (r_debug_addr != 0 && *endp == '\0') {
-      struct r_debug *bootstrap_r_debug = (struct r_debug *) r_debug_addr;
+      struct r_debug* bootstrap_r_debug =

[Roland McGrath, 2013/01/09 18:55:12]

It is probably style-correct to drop 'struct' too.

+          reinterpret_cast<struct r_debug*>(r_debug_addr);
       *bootstrap_r_debug = _r_debug;
 
       // Since the main executable (the bootstrap program) does not
       // have a dynamic section, the debugger will not skip the
       // first element of the link_map list as it usually would for
       // an executable or PIE that was loaded normally.  But the
       // dynamic linker has set l_name for the PIE to "" as is
       // normal for the main executable.  So the debugger doesn't
       // know which file it is.  Fill in the actual file name, which
       // came in as our argv[0].
-      struct link_map *l = _r_debug.r_map;
+      struct link_map* l = _r_debug.r_map;

[Roland McGrath, 2013/01/09 18:55:12]

Same here.

       if (l->l_name[0] == '\0')
         l->l_name = argv0;
     }
   }
 }
 
 // The zygote passes --reserved_at_zero=0xXXXXXXXXXXXXXXXX.
 // nacl_helper_bootstrap replaces the Xs with the amount of prereserved
 // sandbox memory.
 //
 // CheckReservedAtZero parses the value of the argument reserved_at_zero
 // and returns the amount of prereserved sandbox memory.
 static size_t CheckReservedAtZero() {
   size_t prereserved_sandbox_size = 0;
   std::string reserved_at_zero_switch_value =
       CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           kNaClHelperReservedAtZero);
   if (!reserved_at_zero_switch_value.empty()) {
-    char *endp;
+    char* endp;
     prereserved_sandbox_size =
         strtoul(reserved_at_zero_switch_value.c_str(), &endp, 0);
     if (*endp != '\0')
       LOG(ERROR) << "Could not parse reserved_at_zero argument value of "
                  << reserved_at_zero_switch_value;
   }
   return prereserved_sandbox_size;
 }
 
 #if defined(ADDRESS_SANITIZER)
 // Do not install the SIGSEGV handler in ASan. This should make the NaCl
 // platform qualification test pass.
 static const char kAsanDefaultOptionsNaCl[] = "handle_segv=0";
 
 // Override the default ASan options for the NaCl helper.
 // __asan_default_options should not be instrumented, because it is called
 // before ASan is initialized.
 extern "C"
 __attribute__((no_address_safety_analysis))
-const char *__asan_default_options() {
+const char* __asan_default_options() {
   return kAsanDefaultOptionsNaCl;
 }
 #endif
 
-int main(int argc, char *argv[]) {
+int main(int argc, char* argv[]) {
   CommandLine::Init(argc, argv);
   base::AtExitManager exit_manager;
   base::RandUint64();  // acquire /dev/urandom fd before sandbox is raised
 #if !defined(CHROMIUM_SELINUX)
   // Allows NSS to fopen() /dev/urandom.
   sandbox::InitLibcUrandomOverrides();
 #endif
 #if defined(USE_NSS)
   // Configure NSS for use inside the NaCl process.
   // The fork check has not caused problems for NaCl, but this appears to be
@@ skipping 47 matching lines @@
       _exit(-1);
     }
     // if fork fails, send PID=-1 to zygote
     if (!UnixDomainSocket::SendMsg(kNaClZygoteDescriptor, &badpid,
                                    sizeof(badpid), empty)) {
       LOG(ERROR) << "*** send() to zygote failed";
     }
   }
   CHECK(false);  // This routine must not return
 }