Issue 1182633002: Don't crash when main.dart is a 404.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182633002: Don't crash when main.dart is a 404. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium, Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Don't crash when main.dart is a 404. Ideally we would show a failwhale or some such, but I don't know how we would bundle that file with our APK yet. Fixes https://github.com/domokit/mojo/issues/228 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/74de864fcaa930b28b3628292e34ddf369f1bc87

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
M	sky/engine/core/script/dart_controller.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/engine/core/script/dart_loader.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

eseidel

Committed patchset #2 (id:20001) manually as 74de864fcaa930b28b3628292e34ddf369f1bc87 (presubmit successful).

5 years, 6 months ago (2015-06-11 21:07:54 UTC) #3

Hixie

5 years, 6 months ago (2015-06-11 21:51:20 UTC) #5

Message was sent while issue was closed.

Can you redirect to a known good URL? (Assuming that wasn't the URL that failed.
If it was, falling back to this is fine...)