Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3053)

Unified Diff: sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java

Issue 1182633002: Don't crash when main.dart is a 404. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Passes presubmit Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/script/dart_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
diff --git a/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java b/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
index 5a23cc1f249bbda907665bdb8df26ab323c7de97..80340511ac7b2a71228d9107ccfdf2f4d304bec2 100644
--- a/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
+++ b/sky/services/oknet/src/org/domokit/oknet/UrlLoaderImpl.java
@@ -76,9 +76,14 @@ public class UrlLoaderImpl implements UrlLoader {
buffer.put(tmp);
mProducer.endWriteData(result == -1 ? 0 : result);
} catch (MojoException e) {
- if (e.getMojoResult() != MojoResult.SHOULD_WAIT)
+ // No one read the pipe, they just closed it.
+ if (e.getMojoResult() == MojoResult.FAILED_PRECONDITION) {
+ break;
+ } else if (e.getMojoResult() == MojoResult.SHOULD_WAIT) {
+ mCore.wait(mProducer, Core.HandleSignals.WRITABLE, -1);
+ } else {
throw e;
- mCore.wait(mProducer, Core.HandleSignals.WRITABLE, -1);
+ }
} catch (IOException e) {
Log.e(TAG, "mSource.read failed", e);
break;
« no previous file with comments | « sky/engine/core/script/dart_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698