Revert 175753

Revert 175753
> Add a pass/fail test to verify that GPU memory usage doesn't grow beyond an acceptable level when using CSS (managed memory) and WebGL (unmanaged memory).
> 
> BUG=135525
> 
> Review URL: https://chromiumcodereview.appspot.com/11667030

This is causing linux debug compilation failures

TBR=ccameron@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175759

[ccameron, 2013-01-09 17:54:04]

Can you point me to what failed here?

The pre-submit went fine, and the only buildbot message I got was
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...
Which is a different memory test failing (this CL actually doesn't enable
the tests).

C


On Wed, Jan 9, 2013 at 2:02 AM, <ricow@chromium.org> wrote:

> Reviewers: ccameron1,
>
> Description:
> Revert 175753
>
>> Add a pass/fail test to verify that GPU memory usage doesn't grow beyond
>> an
>>
> acceptable level when using CSS (managed memory) and WebGL (unmanaged
> memory).
>
>  BUG=135525
>>
>
>  Review URL:
https://chromiumcodereview.**appspot.com/11667030<https://chromiumcodereview....
>>
>
> This is causing linux debug compilation failures
>
> TBR=ccameron@chromium.org
>
> Please review this at
https://codereview.chromium.**org/11826022/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   D     content/browser/gpu/gpu_**memory_test.cc
>   M     content/common/gpu/gpu_memory_**manager.cc
>   M     content/common/gpu/gpu_**messages.h
>   M     content/content_tests.gypi
>   M     content/public/common/gpu_**memory_stats.h
>   M     content/public/common/gpu_**memory_stats.cc
>   D     content/test/data/gpu/mem_**css3d.html
>   D     content/test/data/gpu/mem_**webgl.html
>
>
>

[Rico, 2013-01-09 18:08:42]

Linux debug compilation
Den 09/01/2013 18.54 skrev "Christopher Cameron" <ccameron@chromium.org>:

> Can you point me to what failed here?
>
> The pre-submit went fine, and the only buildbot message I got was
>
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...
> Which is a different memory test failing (this CL actually doesn't enable
> the tests).
>
> C
>
>
> On Wed, Jan 9, 2013 at 2:02 AM, <ricow@chromium.org> wrote:
>
>> Reviewers: ccameron1,
>>
>> Description:
>> Revert 175753
>>
>>> Add a pass/fail test to verify that GPU memory usage doesn't grow beyond
>>> an
>>>
>> acceptable level when using CSS (managed memory) and WebGL (unmanaged
>> memory).
>>
>>  BUG=135525
>>>
>>
>>  Review URL:
https://chromiumcodereview.**appspot.com/11667030<https://chromiumcodereview....
>>>
>>
>> This is causing linux debug compilation failures
>>
>> TBR=ccameron@chromium.org
>>
>> Please review this at
https://codereview.chromium.**org/11826022/<https://codereview.chromium.org/1...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>>
>> Affected files:
>>   D     content/browser/gpu/gpu_**memory_test.cc
>>   M     content/common/gpu/gpu_memory_**manager.cc
>>   M     content/common/gpu/gpu_**messages.h
>>   M     content/content_tests.gypi
>>   M     content/public/common/gpu_**memory_stats.h
>>   M     content/public/common/gpu_**memory_stats.cc
>>   D     content/test/data/gpu/mem_**css3d.html
>>   D     content/test/data/gpu/mem_**webgl.html
>>
>>
>>
>

[ccameron, 2013-01-09 18:22:31]

Is there a buildbot link?

C

On Wed, Jan 9, 2013 at 10:08 AM, Rico Wind <ricow@chromium.org> wrote:

> Linux debug compilation
> Den 09/01/2013 18.54 skrev "Christopher Cameron" <ccameron@chromium.org>:
>
> Can you point me to what failed here?
>>
>> The pre-submit went fine, and the only buildbot message I got was
>>
>>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...
>> Which is a different memory test failing (this CL actually doesn't enable
>> the tests).
>>
>> C
>>
>>
>> On Wed, Jan 9, 2013 at 2:02 AM, <ricow@chromium.org> wrote:
>>
>>> Reviewers: ccameron1,
>>>
>>> Description:
>>> Revert 175753
>>>
>>>> Add a pass/fail test to verify that GPU memory usage doesn't grow
>>>> beyond an
>>>>
>>> acceptable level when using CSS (managed memory) and WebGL (unmanaged
>>> memory).
>>>
>>>  BUG=135525
>>>>
>>>
>>>  Review URL:
https://chromiumcodereview.**appspot.com/11667030<https://chromiumcodereview....
>>>>
>>>
>>> This is causing linux debug compilation failures
>>>
>>> TBR=ccameron@chromium.org
>>>
>>> Please review this at
https://codereview.chromium.**org/11826022/<https://codereview.chromium.org/1...
>>>
>>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>>>
>>> Affected files:
>>>   D     content/browser/gpu/gpu_**memory_test.cc
>>>   M     content/common/gpu/gpu_memory_**manager.cc
>>>   M     content/common/gpu/gpu_**messages.h
>>>   M     content/content_tests.gypi
>>>   M     content/public/common/gpu_**memory_stats.h
>>>   M     content/public/common/gpu_**memory_stats.cc
>>>   D     content/test/data/gpu/mem_**css3d.html
>>>   D     content/test/data/gpu/mem_**webgl.html
>>>
>>>
>>>
>>

[Rico, 2013-01-09 18:37:20]

Yes, sorry
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Cheers,
Rico

On Wed, Jan 9, 2013 at 7:22 PM, Christopher Cameron
<ccameron@chromium.org>wrote:

> Is there a buildbot link?
>
> C
>
>
> On Wed, Jan 9, 2013 at 10:08 AM, Rico Wind <ricow@chromium.org> wrote:
>
>> Linux debug compilation
>> Den 09/01/2013 18.54 skrev "Christopher Cameron" <ccameron@chromium.org>:
>>
>> Can you point me to what failed here?
>>>
>>> The pre-submit went fine, and the only buildbot message I got was
>>>
>>>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...
>>> Which is a different memory test failing (this CL actually doesn't
>>> enable the tests).
>>>
>>> C
>>>
>>>
>>> On Wed, Jan 9, 2013 at 2:02 AM, <ricow@chromium.org> wrote:
>>>
>>>> Reviewers: ccameron1,
>>>>
>>>> Description:
>>>> Revert 175753
>>>>
>>>>> Add a pass/fail test to verify that GPU memory usage doesn't grow
>>>>> beyond an
>>>>>
>>>> acceptable level when using CSS (managed memory) and WebGL (unmanaged
>>>> memory).
>>>>
>>>>  BUG=135525
>>>>>
>>>>
>>>>  Review URL:
https://chromiumcodereview.**appspot.com/11667030<https://chromiumcodereview....
>>>>>
>>>>
>>>> This is causing linux debug compilation failures
>>>>
>>>> TBR=ccameron@chromium.org
>>>>
>>>> Please review this at
https://codereview.chromium.**org/11826022/<https://codereview.chromium.org/1...
>>>>
>>>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>>>>
>>>> Affected files:
>>>>   D     content/browser/gpu/gpu_**memory_test.cc
>>>>   M     content/common/gpu/gpu_memory_**manager.cc
>>>>   M     content/common/gpu/gpu_**messages.h
>>>>   M     content/content_tests.gypi
>>>>   M     content/public/common/gpu_**memory_stats.h
>>>>   M     content/public/common/gpu_**memory_stats.cc
>>>>   D     content/test/data/gpu/mem_**css3d.html
>>>>   D     content/test/data/gpu/mem_**webgl.html
>>>>
>>>>
>>>>
>>>
>

[ccameron, 2013-01-09 19:05:44]

Thanks.

Ugh, this is probably some definition of GPU_EXPORT that varies from
platform to platform (and somehow it worked on my local Linux build but not
the bot).  I'll re-add the change minus the flag, and then try to sort out
what's up with it.

C

On Wed, Jan 9, 2013 at 10:37 AM, Rico Wind <ricow@chromium.org> wrote:

>
> Yes, sorry
>
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%...
>
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
>
> Cheers,
> Rico
>
>
> On Wed, Jan 9, 2013 at 7:22 PM, Christopher Cameron <ccameron@chromium.org
> > wrote:
>
>> Is there a buildbot link?
>>
>> C
>>
>>
>> On Wed, Jan 9, 2013 at 10:08 AM, Rico Wind <ricow@chromium.org> wrote:
>>
>>> Linux debug compilation
>>> Den 09/01/2013 18.54 skrev "Christopher Cameron" <ccameron@chromium.org
>>> >:
>>>
>>> Can you point me to what failed here?
>>>>
>>>> The pre-submit went fine, and the only buildbot message I got was
>>>>
>>>>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...
>>>> Which is a different memory test failing (this CL actually doesn't
>>>> enable the tests).
>>>>
>>>> C
>>>>
>>>>
>>>> On Wed, Jan 9, 2013 at 2:02 AM, <ricow@chromium.org> wrote:
>>>>
>>>>> Reviewers: ccameron1,
>>>>>
>>>>> Description:
>>>>> Revert 175753
>>>>>
>>>>>> Add a pass/fail test to verify that GPU memory usage doesn't grow
>>>>>> beyond an
>>>>>>
>>>>> acceptable level when using CSS (managed memory) and WebGL (unmanaged
>>>>> memory).
>>>>>
>>>>>  BUG=135525
>>>>>>
>>>>>
>>>>>  Review URL:
https://chromiumcodereview.**appspot.com/11667030<https://chromiumcodereview....
>>>>>>
>>>>>
>>>>> This is causing linux debug compilation failures
>>>>>
>>>>> TBR=ccameron@chromium.org
>>>>>
>>>>> Please review this at
https://codereview.chromium.**org/11826022/<https://codereview.chromium.org/1...
>>>>>
>>>>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>>>>>
>>>>> Affected files:
>>>>>   D     content/browser/gpu/gpu_**memory_test.cc
>>>>>   M     content/common/gpu/gpu_memory_**manager.cc
>>>>>   M     content/common/gpu/gpu_**messages.h
>>>>>   M     content/content_tests.gypi
>>>>>   M     content/public/common/gpu_**memory_stats.h
>>>>>   M     content/public/common/gpu_**memory_stats.cc
>>>>>   D     content/test/data/gpu/mem_**css3d.html
>>>>>   D     content/test/data/gpu/mem_**webgl.html
>>>>>
>>>>>
>>>>>
>>>>
>>
>