Browser Plugin: Implement BrowserPluginObserver.

content/renderer/browser_plugin/browser_plugin_manager.h

Index: content/renderer/browser_plugin/browser_plugin_manager.h
diff --git a/content/renderer/browser_plugin/browser_plugin_manager.h b/content/renderer/browser_plugin/browser_plugin_manager.h
index b6dab830412a29dc61ba2fe355a116ceb27cc21d..d245aea60e39555940bbe214ea38d64fde889363 100644
--- a/content/renderer/browser_plugin/browser_plugin_manager.h
+++ b/content/renderer/browser_plugin/browser_plugin_manager.h
@@ -19,7 +19,7 @@ struct WebPluginParams;
 
 namespace content {
 
-class BrowserPlugin;
+class BrowserPluginImpl;
 class BrowserPluginManagerFactory;
 class RenderViewImpl;
 
@@ -44,17 +44,19 @@ class CONTENT_EXPORT BrowserPluginManager
   // BrowserPlugin is responsible for associating itself with the
   // BrowserPluginManager via AddBrowserPlugin. When it is destroyed, it is
   // responsible for removing its association via RemoveBrowserPlugin.
-  virtual BrowserPlugin* CreateBrowserPlugin(
+  virtual BrowserPluginImpl* CreateBrowserPlugin(
       RenderViewImpl* render_view,
       WebKit::WebFrame* frame,
       const WebKit::WebPluginParams& params) = 0;
 
-  void AddBrowserPlugin(int instance_id, BrowserPlugin* browser_plugin);
+  void AddBrowserPlugin(int instance_id, BrowserPluginImpl* browser_plugin);
   void RemoveBrowserPlugin(int instance_id);
-  BrowserPlugin* GetBrowserPlugin(int instance_id) const;
+  BrowserPluginImpl* GetBrowserPlugin(int instance_id) const;
   void SetEmbedderFocus(const RenderViewImpl* embedder, bool focused);
   RenderViewImpl* render_view() const { return render_view_; }
 
+  void RequestMessage(uint32 message_id);

[sadrul, 2013/01/09 15:21:54]

doc

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+
   // RenderViewObserver implementation.
 
   // BrowserPluginManager must override the default Send behavior.
@@ -70,13 +72,19 @@ class CONTENT_EXPORT BrowserPluginManager
   // Friend RefCounted so that the dtor can be non-public.
   friend class base::RefCounted<BrowserPluginManager>;
 
+

[sadrul, 2013/01/09 15:21:54]

too many new lines

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+  // Returns whether a message should be forwarded to BrowserPlugins.
+  bool ShouldForwardToBrowserPlugin(const IPC::Message& message);
+
   // Static factory instance (always NULL for non-test).
   static BrowserPluginManagerFactory* factory_;
 
   virtual ~BrowserPluginManager();
-  IDMap<BrowserPlugin> instances_;
+  IDMap<BrowserPluginImpl> instances_;
   base::WeakPtr<RenderViewImpl> render_view_;
   int browser_plugin_counter_;
+  // Set of messages requested by BrowserPluginObservers.
+  std::set<uint32> browser_plugin_messages_;
 };

[sadrul, 2013/01/09 15:21:54]

You should have a DISALLOW_COPY_AND_ASSIGN inside a private block here.

[Fady Samuel, 2013/01/09 17:41:24]

Done.

 
 }  // namespace content